You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a fallback value for top offset of ScrollyMapContainer: When topOffset is undefined it causes the css top property to be faulty, which makes the position: sticky not working.
Notes & Questions About Changes
Do we still need the whole useSlidingStickyHeaderProps logic with the USWDS header?
Validation / Testing
You will to validate in the next-veda instance, making sure the map stays sticky on the top when scrolling down.
Related PR on next-veda-ui: developmentseed/next-veda-ui#41
I believe useSlidingStickyHeaderProps is not necessary for the new uswds header ( that hook was there becauase we showed/hid the header based on scroll direction, and we ditched that behavior for the new header). The deploy preview from the pr you linked - https://deploy-preview-41--veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19 Scrollytelling block still doesn't work for me. Can you take a look?
Yeah, I noticed the deploy preview isn't updating the library correctly. I need to figure out how to make it use this branch. Still not an expert on our verdaccio setup — and hopefully, I won't have to become one! 😅
This PR probably didn't introduce the bug, but if its intention was to handle #1402, I think it is the same issue. (Feel free to handle it in whichever way you prefer! I mainly wanted to flag what I found!)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: Fix #1402
Description of Changes
Provide a fallback value for top offset of ScrollyMapContainer: When
topOffsetis undefined it causes the csstopproperty to be faulty, which makes theposition: stickynot working.Notes & Questions About Changes
Do we still need the whole
useSlidingStickyHeaderPropslogic with the USWDS header?Validation / Testing
You will to validate in the next-veda instance, making sure the map stays sticky on the top when scrolling down.
Related PR on next-veda-ui: developmentseed/next-veda-ui#41