Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Scrollytelling layout in Next instance #1402

Closed
1 task done
Tracked by #1282
AliceR opened this issue Jan 27, 2025 · 0 comments · Fixed by #1408
Closed
1 task done
Tracked by #1282

Fix Scrollytelling layout in Next instance #1402

AliceR opened this issue Jan 27, 2025 · 0 comments · Fixed by #1408
Labels
veda v2 VEDA Refactor Epic Work

Comments

@AliceR
Copy link
Member

AliceR commented Jan 27, 2025 •
edited
Loading

Context

ScrollytellingBlock styling needs to be fixed to match existing, including ensuring all frames populate with the correct layer and basemap. You can see the problem from : https://veda-ui-next-test.netlify.app/stories/air-quality-and-covid-19

Acceptance Criteria

  • Map is fixed and content scrolls over as intended
@AliceR AliceR mentioned this issue Jan 27, 2025
Open
13 tasks
@AliceR AliceR marked this as a duplicate of #1403 Jan 27, 2025
@sandrahoang686 sandrahoang686 added the veda v2 VEDA Refactor Epic Work label Jan 27, 2025
This was referenced Jan 28, 2025
Merged
Merged
AliceR added a commit that referenced this issue Jan 29, 2025
@AliceR
fix: Scrollytelling layout in Next instance (#1408)
168a990 
**Related Ticket:** #1402 

### Description of Changes
Provide a fallback value for top offset of ScrollyMapContainer: When
`topOffset` is undefined it causes the css `top` property to be faulty,
which makes the `position: sticky` not working.

### Notes & Questions About Changes
Do we still need the whole `useSlidingStickyHeaderProps` logic with the
USWDS header?

### Validation / Testing
You will to validate in the next-veda instance, making sure the map
stays sticky on the top when scrolling down.
Related PR on next-veda-ui:
developmentseed/next-veda-ui#41
@AliceR AliceR closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
veda v2 VEDA Refactor Epic Work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Scrollytelling layout in Next instance NASA-IMPACT/veda-ui
2 participants
@AliceR @sandrahoang686