-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING(collections): deprecate groupBy()
#3663
Conversation
Related to #3594. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types for Object.groupBy()
and Map.groupBy()
were added in Deno v1.38.
This change looks reasonable and good to me. Thanks!
Deprecation makes sense to me, but safari still doesn't support this according to MDN https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/groupBy I'm afraid we might get similar reaction to the case of |
Not sure about this. I'm still considering |
We updated the deprecation policy in #3807 Now we recommend the users to pin the URL to the old std version if they still need them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
groupBy
can be replaced byObject.groupBy
in Deno 1.37. Creating this as a draft for now because the TypeScript lib isn't updated, but running this without typechecking passes fine.