-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we slow down deprecation/removal to support the usage in browsers? #3594
Comments
I think it makes sense to keep some APIs only for supporting browsers because we support and promote Fresh for web app development, and it encourages the mixed style of server-side and client-side programming. |
I feel like there's almost an opportunity for a |
Do you mean we should provide |
That was my feeling, yes. We could also not do shims and tell people to look for more well-known solutions (corejs), but I'm not really too sure about that. It feels like shims for semi-modern (post IE) runtimes could be useful. |
We could just provide some ponyfills if needed. I'm kind of swaying back and forth on this one. The docs should be really clear what method to use instead in modern runtimes. |
My specific use case was for shunting some server-side Deno code into a ServiceWorker, it would certainly be handy if std provider something like the suggested |
I like the idea of a polyfill until sufficient browser support for a particular API exists. I think it should have the following properties:
|
Alternatively, we now have a Deprecation Policy, which has an answer for these use cases - use an older pinned version of the Standard Library. Should we be happy with that answer or provide polyfills? My concern is that we can get carried away with polyfills and start to compete with other libraries, such as core-js, which I don't think we should do. |
Closing as we decided on the deprecation policy. @lino-levan Please open a new issue if you still feel strongly about |
It may also be helpful in deprecation notices to provide links to third-party polyfills. To at least confirm there is a polyfill before deprecation. |
Yeah, that might be a good idea too. |
I think I've more or less decided that the deno standard library should be focused on providing support for deno programs. We really do not want to get into the headache that is polyfills. Community projects are much better for that imo. I think it would be cool if someone put the std ponyfills into something like Pinning to an old version of std seems reasonable to me. |
We deprecated and removed
readableStreamFromIterable
instd/streams
because Deno implementedReadableStream.from
in v1.35, which overlaps withreadableStreamFromIterable
.However the above removal affected the user who uses
readableStreamFromIterable
in Web browsers (Note:ReadableStream.from
is not yet available in browsers except firefox). See #3579 (comment) )Should we slow down our deprecation/removal pace to better support such use cases? (Especially 'removal')
The text was updated successfully, but these errors were encountered: