Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ReadableStream.from #19446

Merged
merged 6 commits into from
Jul 2, 2023
Merged

feat: ReadableStream.from #19446

merged 6 commits into from
Jul 2, 2023

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Jun 9, 2023 •
edited
Loading

Closes #19417

@crowlKats
Copy link
Member Author

@petamoriken unsure how to handle the primordials iterator issue here

@petamoriken
Copy link
Contributor

@crowlKats Simply add // deno-lint-ignore prefer-primordials 🙇

If we use GeneratorFunction in Deno internal, we need to handle it appropriately such as GeneratorPrototypeNext, but in this case, it is a code to receive AsyncIterable from userland, so we should ignore it.

crowlKats
crowlKats commented Jun 10, 2023
View reviewed changes
tools/wpt/expectation.json Outdated Show resolved Hide resolved
0f-0b
0f-0b reviewed Jun 10, 2023
View reviewed changes
ext/web/06_streams.js Outdated Show resolved Hide resolved
@bartlomieju bartlomieju added this to the 1.35 milestone Jun 11, 2023
lucacasonato
lucacasonato reviewed Jun 29, 2023
View reviewed changes
ext/web/06_streams.js Outdated Show resolved Hide resolved
bartlomieju
bartlomieju approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crowlKats crowlKats merged commit 805497a into denoland:main Jul 2, 2023
@crowlKats crowlKats deleted the readablestream_from branch July 2, 2023 17:30
@ayame113 ayame113 mentioned this pull request Jul 10, 2023
Closed
@MattiasBuelens MattiasBuelens mentioned this pull request Jul 20, 2023
Open
@kt3k kt3k mentioned this pull request Aug 31, 2023
Closed
@KnorpelSenf KnorpelSenf mentioned this pull request Sep 9, 2023
Closed
@jcbhmr jcbhmr mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato left review comments

@0f-0b 0f-0b 0f-0b left review comments

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.35
Development

Successfully merging this pull request may close these issues.

Streams: support ReadableStream.from()
5 participants
@crowlKats @petamoriken @lucacasonato @0f-0b @bartlomieju