Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING(collections): remove groupBy() #3923

Merged
merged 2 commits into from
Dec 22, 2023
Merged

BREAKING(collections): remove groupBy() #3923

merged 2 commits into from
Dec 22, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Dec 11, 2023 •
edited by kt3k
Loading

To be merged for v0.211.0.

See also #3663

@iuioiua iuioiua closed this Dec 18, 2023
@iuioiua iuioiua reopened this Dec 21, 2023
@iuioiua iuioiua marked this pull request as ready for review December 21, 2023 20:17
@iuioiua iuioiua requested a review from kt3k as a code owner December 21, 2023 20:17
@iuioiua iuioiua enabled auto-merge (squash) December 22, 2023 10:32
kt3k
kt3k approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 59229e0 into main Dec 22, 2023
11 checks passed
@iuioiua iuioiua deleted the remove-collections-groupby branch December 22, 2023 10:33
@av
Copy link

av commented Oct 22, 2024

This change made me greatly confused while exploring @std/collections.

groupBy is the main reason why I'm reaching out to lodash-like libraries, so not being able to find it at first, and then having to discover it was removed (without a trace of explanation) was a bit frustrating.

@iuioiua
Copy link
Contributor Author

iuioiua commented Oct 22, 2024

Apologies, @av. Yes, we should've included relevant info. groupBy() was replaced by the JS-native Object.groupBy().

@av
Copy link

av commented Oct 22, 2024

Thanks for getting back to me. I figured it out, just wanted to leave some feedback for the team. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
collections
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iuioiua @av @kt3k