upstream changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Géry Ogam <[email protected]>
Previously, the mtime was the default value of 0. Fixes #670. This stops the following warning when using gnu tar: implausibly old time stamp 1970-01-01 01:00:00
replace deprecated GPL identifiers with their new version
Fix "support for support" mistake at changelog
Support installing and uninstalling on Fish shell
* CHANGE: output by `poetry version` simplified to `<project_name> <version>` * FIX: adopt `test_version_show` to recognize new output format
This is probably only a typo. `importlib-metadata` was included in the standard library, so the requirement should be `< 3.8`, not `<= 3.8`.
…ge section and also in the CLI. Resolves #1848.
Document --no-root
Configuring the template chooser to include discord community server.
If multiple distributions have `tests` as a top-level package, they'll conflict whenever both are installed. (Examples [here]((https://github.com/python-poetry/poetry/issues/1905) and [here](NixOS/nixpkgs#81482). Two common alternative strategies are: 1. not distributing tests (as [here](https://github.com/pypa/sampleproject)), or 2. placing tests in a subdirectory of the main package, rather than adjacent (as [here](http://blog.habnab.it/blog/2013/07/21/python-packages-and-you/) and [here](http://as.ynchrono.us/2007/12/filesystem-structure-of-python-project_21.html)). Each of these strategies will avoid this issue. Users may fall into this trap because of the [package documentation](https://python-poetry.org/docs/pyproject/#packages) page, which gives an example: ``` packages = [ { include = "my_package" }, { include = "tests", format = "sdist" }, ] ``` Having two top-level packages in a distribution is relatively unusual, but does have some use cases. Using `"tests"` as a top-level package name in the example is likely to lead to conflicts, however. The alternate package in the documentation example could have a unique name like `"my_other_package"`, which would reduce the likelihood of this kind of overlap.
* Add fish shell tab completion for mac * Remove macOS ref as brew should work linux as well
Co-authored-by: [email protected] <GiWahnsinn07!>
When testing the behavior for git packages with a setup.py file, the Provider class would create a temporary virtual environment and execute python setup.py egg_info. Both actions are costly and take time. By mocking them, we can reduce the tests time by a factor of 4 or 5.
'An' should come before a vowel sound. Reference: https://english.stackexchange.com/a/164/198117
Co-Authored-By: Pradyun Gedam <[email protected]> Co-authored-by: Pradyun Gedam <[email protected]>
Co-Authored-By: Pradyun Gedam <[email protected]>
Signed-off-by: oleg.hoefling <[email protected]>
* fix incorrect parsing of spaces when parsing version constraints * add tests for `parse_constraint`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
Note: If your Pull Request introduces a new feature or changes the current behavior, it should be based
on the
developbranch. If it's a bug fix or only a documentation update, it should be based on themasterbranch.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!