Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't require importlib-metadata with python 3.8 #1586

Merged
merged 1 commit into from
Nov 18, 2019
Merged

don't require importlib-metadata with python 3.8 #1586

merged 1 commit into from
Nov 18, 2019

Conversation

decathorpe
Copy link
Contributor

@decathorpe decathorpe commented Nov 15, 2019

This is probably only a typo.

importlib-metadata was included in the standard library with 3.8, so the requirement should be < 3.8, not <= 3.8.

Fixes: #1487

This is probably only a typo.

`importlib-metadata` was included in the standard library, so the requirement should be `< 3.8`, not `<= 3.8`.
Copy link
Member

@sdispater sdispater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sdispater sdispater merged commit bf6ad08 into python-poetry:master Nov 18, 2019
shenek pushed a commit to shenek/poetry that referenced this pull request Dec 31, 2019
This is probably only a typo.

`importlib-metadata` was included in the standard library, so the requirement should be `< 3.8`, not `<= 3.8`.
Copy link

github-actions bot commented Mar 1, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'importlib_metadata' with python3.8
2 participants