Support installing and uninstalling on Fish shell #1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the `POETRY_HOME` environment variable to be passed during installation to change the default installation directory of `~/.poetry`: ``` POETRY_HOME=/etc/poetry python get-poetry.py ```
…1459) * * check if relative filename is in excluded file list * removed find_excluded_files() method from wheel.py * added test for excluding files in wheels * creating an own test data folder, for testing excluding files by pyproject.toml * use as_posix() to respect windows file path delimiters
* This PR impliments the feature request python-poetry#784. When a folder is explicit defined in `pyproject.toml` as excluded, all nested data, including subfolder, are excluded. It is no longer neccessary to use the glob `folder/**/*` * use `Path` instead of `os.path.join` to create string for globbing * try to fix linting error * create glob pattern string by concatenating and not using Path * using `os.path.isdir()`` for checking of explicit excluded name is a folder, because pathlib's `is_dir()` raises in exception under windows of name contains globing characters * Remove nested data when wildcards where used. Steps to do this are: 1. expand any wildcard used 2. if expanded path is a folder append **/* and expand again * fix linting * only glob a second time if path is dir * implement @sdispater 's suggestion for better readability * fix glob for windows? * On Windows, testing if a path with a glob is a directory will raise an OSError * pathlibs glob function doesn't return the correct case (https://bugs.python.org/issue26655). So switching back to glob.glob() * removing obsolete imports
3 tasks
eblume
reviewed
Nov 8, 2019
kasteph
reviewed
Nov 15, 2019
There was a problem hiding this comment.
@justinmayer thank you for this PR! Could you fix the linting issue then this'll be good to merge!
|
@stephsamson: Thanks for reviewing. As far as I can tell, that appears to be a glitch with GitHub Actions. If you look at the output, the cause shows: The actual linting step appears to pass without problems. Would you mind taking another look? |
In order to enhance support for multiple shells in the installation script, this moves shell type detection outside the `get_unix_profiles` function so it can be available to multiple functions.
Previously, the install script mentioned $PATH modifications that do not apply to Fish. Users may have thought everything was all set up, only to find invoking the `poetry` executable would fail in a Fish shell environment because Poetry's bin directory could not be found on $PATH. Now, if Poetry's bin directory is not found in Fish's $PATH environment variable, that directory is added to the `fish_user_paths` universal variable, making the `poetry` executable immediately available to current and future Fish shell sessions.
justinmayer
force-pushed
the
get_poetry_fish
branch
from
9029024 to
f681337
Compare
|
@stephsamson: I triggered a new build, and I suspected, this was most likely a GitHub CI glitch. All tests are now passing — I think this is ready to merge. |
|
Woo! Thanks @justinmayer 🚀 one more thing, it makes more sense to merge this against |
finswimmer
pushed a commit
to finswimmer/poetry
that referenced
this pull request
Nov 22, 2019
Support installing and uninstalling on Fish shell
shenek
pushed a commit
to shenek/poetry
that referenced
this pull request
Dec 31, 2019
Support installing and uninstalling on Fish shell
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the install script mentioned $PATH modifications that do not
apply to Fish. Users may have thought everything was all set up, only to
find invoking the
poetryexecutable would fail in a Fish shellenvironment because Poetry's bin directory could not be found on $PATH.
Now, if Poetry's bin directory is not found in Fish's $PATH environment
variable, that directory is added to the
fish_user_pathsuniversalvariable, making the
poetryexecutable immediately available tocurrent and future Fish shell sessions.
Fixes #544