Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SimpBMS MaxChargingCurrent scaling #146

Merged
merged 1 commit into from
Jan 25, 2025
Merged

Fix SimpBMS MaxChargingCurrent scaling #146

merged 1 commit into from
Jan 25, 2025

Conversation

chrskly
Copy link
Contributor

@chrskly chrskly commented Jan 22, 2025

Fix for #77

@chrskly chrskly mentioned this pull request Jan 22, 2025
Closed
@Tom-evnut Tom-evnut closed this Jan 25, 2025
@Tom-evnut Tom-evnut reopened this Jan 25, 2025
Tom-evnut
Tom-evnut approved these changes Jan 25, 2025
View reviewed changes
Copy link
Collaborator

@Tom-evnut Tom-evnut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, good to add and close issue.

@Tom-evnut Tom-evnut merged commit 6546abd into damienmaguire:master Jan 25, 2025
2 checks passed
@chrskly
Copy link
Contributor Author

chrskly commented Jan 25, 2025

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tom-evnut Tom-evnut Tom-evnut approved these changes

@damienmaguire damienmaguire Awaiting requested review from damienmaguire damienmaguire is a code owner

@jsphuebner jsphuebner Awaiting requested review from jsphuebner jsphuebner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrskly @Tom-evnut