-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simp BMS Charge current scale factor #77
Comments
I have noticed the same issue and didnt bother to mess with it as i really dont need this feature. but glad that you found what the issue is. |
@Tom-evnut Can confirm that the scaling is currently incorrect. I've corrected it in my offline build on the bench. |
@Mitchy6 Please provide corrective lines of code and I can push this in. |
Submitted a PR that I think will fix this. Bear in mind I don't have a ZombieVerter, so, this is just based on me eyeballing the code. |
Code merged |
I am using the simp BMS option in the VCU. The BMS_ChargeLim value in the web interface seems wrong. Looking in the simpbms.cpp, the chargeCurrentLimit is divided by 1000. The simp_BMS datasheet states that this value is scaled by 10.
The text was updated successfully, but these errors were encountered: