Merge pull request #146 from chrskly/simpbms_maxchargecurrent_scaling

Fix SimpBMS MaxChargingCurrent scaling
damienmaguire · Jan 25, 2025 · 6546abd · 6546abd
2 parents e83e9f4 + 99b997f
commit 6546abd
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/include/simpbms.h b/include/simpbms.h
@@ -34,7 +34,7 @@ class SimpBMS: public BMS
    private:
       bool BMSDataValid();
       bool ChargeAllowed();
-      int chargeCurrentLimit = 0;
+      int chargeCurrentLimit = 0;  // Sent by Simp as 0.1A per digit and stored the same way.
       int timeoutCounter = 0;
       float minCellV = 0;
       float maxCellV = 0;

diff --git a/src/simpbms.cpp b/src/simpbms.cpp
@@ -64,7 +64,7 @@ bool SimpBMS::ChargeAllowed()
 float SimpBMS::MaxChargeCurrent()
 {
    if(!ChargeAllowed()) return 0;
-   return chargeCurrentLimit / 1000.0;
+   return chargeCurrentLimit * 0.1;
 }
 
 // Process voltage and temperature message from SimpBMS.