-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
housekeeping #1170
Merged
Merged
housekeeping #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on--courteous-roseate-spoonbill-7d54882561
github-actions
bot
added
plugins/css-has-pseudo
plugins/postcss-focus-within
plugins/postcss-custom-media
plugins/postcss-lab-function
plugins/postcss-logical
plugin-packs/postcss-preset-env
common-tools
cli
plugins/postcss-hwb-function
plugins/postcss-color-function
plugins/postcss-oklab-function
plugins/postcss-gradients-interpolation-method
plugins/postcss-design-tokens
plugins/postcss-extract
plugins/postcss-logical-viewport-units
plugins/postcss-logical-resize
plugins/postcss-color-mix-function
plugins/postcss-media-minmax
plugins/postcss-relative-color-syntax
stylelint-plugin
plugins/postcss-exponential-functions
plugin-packs/postcss-bundler
labels
Nov 4, 2023
github-actions
bot
added
plugins/postcss-overflow-shorthand
plugins/postcss-place
plugins/postcss-is-pseudo-class
plugins/postcss-cascade-layers
plugins/postcss-nested-calc
plugins/media-queries-aspect-ratio-number-values
plugins/postcss-media-queries-aspect-ratio-number-values
plugins/postcss-global-data
labels
Nov 5, 2023
…ing-guppy-73a9343012
…ing-guppy-73a9343012
This was referenced Dec 1, 2023
Antonio-Laguna
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! TIL about knip
thanks for this!
…ing-guppy-73a9343012
Thank you for reviewing all this @Antonio-Laguna 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
common-tools
experimental
plugin-packs/postcss-bundler
plugin-packs/postcss-preset-env
plugins/css-blank-pseudo
plugins/css-has-pseudo
plugins/media-queries-aspect-ratio-number-values
plugins/postcss-media-queries-aspect-ratio-number-values
plugins/postcss-attribute-case-insensitive
plugins/postcss-cascade-layers
plugins/postcss-color-function
plugins/postcss-color-mix-function
plugins/postcss-custom-media
plugins/postcss-custom-properties
plugins/postcss-custom-selectors
plugins/postcss-design-tokens
plugins/postcss-dir-pseudo-class
plugins/postcss-double-position-gradients
plugins/postcss-env-function
plugins/postcss-exponential-functions
plugins/postcss-extract
plugins/postcss-focus-visible
plugins/postcss-focus-within
plugins/postcss-global-data
plugins/postcss-gradients-interpolation-method
plugins/postcss-hwb-function
plugins/postcss-image-set-function
plugins/postcss-is-pseudo-class
plugins/postcss-lab-function
plugins/postcss-logical
plugins/postcss-logical-resize
plugins/postcss-logical-viewport-units
plugins/postcss-media-minmax
plugins/postcss-nested-calc
plugins/postcss-nesting
plugins/postcss-oklab-function
plugins/postcss-overflow-shorthand
plugins/postcss-place
plugins/postcss-pseudo-class-any-link
plugins/postcss-relative-color-syntax
plugins/postcss-scope-pseudo-class
plugins/postcss-selector-not
plugins/postcss-stepped-value-functions
PostCSS Stepped Value Functions
plugins/postcss-trigonometric-functions
PostCSS Trigonometric Functions
plugins/postcss-unset-value
stylelint-plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
knip
as a static analysis tool.In general it seems be good at finding redundant exports and dependencies and also missing dependency declarations.
It does this both for
npm
packages inpackage.json
and for TypeScript.it can do more, but the above is what it does for us
I've also added
strict
mode in TypeScript in more packages.For the
css-color-parser
I also wrote more JS Doc comments and added anExperimental
syntax flag for future use. TheExperimental
flag will allow us to roll out new features likecontrast-color
in a more controlled manner.