Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

housekeeping #1170

Merged
merged 26 commits into from
Dec 4, 2023
Merged

housekeeping #1170

merged 26 commits into from
Dec 4, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Nov 4, 2023

I've added knip as a static analysis tool.

In general it seems be good at finding redundant exports and dependencies and also missing dependency declarations.

It does this both for npm packages in package.json and for TypeScript.

it can do more, but the above is what it does for us


I've also added strict mode in TypeScript in more packages.


For the css-color-parser I also wrote more JS Doc comments and added an Experimental syntax flag for future use. The Experimental flag will allow us to roll out new features like contrast-color in a more controlled manner.

@github-actions github-actions bot added the e2e label Nov 6, 2023
@github-actions github-actions bot removed the e2e label Nov 14, 2023
Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! TIL about knip thanks for this!

@romainmenke
Copy link
Member Author

Thank you for reviewing all this @Antonio-Laguna 🙇

@romainmenke romainmenke merged commit 39be5ce into main Dec 4, 2023
7 checks passed
@romainmenke romainmenke deleted the housekeeping--unassuming-guppy-73a9343012 branch December 4, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common-tools experimental plugin-packs/postcss-bundler plugin-packs/postcss-preset-env plugins/css-blank-pseudo plugins/css-has-pseudo plugins/media-queries-aspect-ratio-number-values plugins/postcss-media-queries-aspect-ratio-number-values plugins/postcss-attribute-case-insensitive plugins/postcss-cascade-layers plugins/postcss-color-function plugins/postcss-color-mix-function plugins/postcss-custom-media plugins/postcss-custom-properties plugins/postcss-custom-selectors plugins/postcss-design-tokens plugins/postcss-dir-pseudo-class plugins/postcss-double-position-gradients plugins/postcss-env-function plugins/postcss-exponential-functions plugins/postcss-extract plugins/postcss-focus-visible plugins/postcss-focus-within plugins/postcss-global-data plugins/postcss-gradients-interpolation-method plugins/postcss-hwb-function plugins/postcss-image-set-function plugins/postcss-is-pseudo-class plugins/postcss-lab-function plugins/postcss-logical plugins/postcss-logical-resize plugins/postcss-logical-viewport-units plugins/postcss-media-minmax plugins/postcss-nested-calc plugins/postcss-nesting plugins/postcss-oklab-function plugins/postcss-overflow-shorthand plugins/postcss-place plugins/postcss-pseudo-class-any-link plugins/postcss-relative-color-syntax plugins/postcss-scope-pseudo-class plugins/postcss-selector-not plugins/postcss-stepped-value-functions PostCSS Stepped Value Functions plugins/postcss-trigonometric-functions PostCSS Trigonometric Functions plugins/postcss-unset-value stylelint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants