Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

color-helpers: uniform TypeScript setup #1190

Merged

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Dec 1, 2023

types/color was interpreted as "an npm package with name types"

So I removed the baseUrl config and updated all the paths so that the emitted types do not have this issue.

This also makes the TypeScript setup more uniform with other packages


see : #1170

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romainmenke romainmenke merged commit 46c1093 into main Dec 4, 2023
7 checks passed
@romainmenke romainmenke deleted the color-helpers--unassuming-sumatran-elephant-ca3ae6a86c branch December 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants