Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css-calc: cleanup exported functions #1191

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

romainmenke
Copy link
Member

@romainmenke romainmenke commented Dec 1, 2023

Too many functions, constants, ... were exported by default.
Even when they were never used externally.

Only exporting the needed bits results in a cleaner public TypeScript interface.


see : #1170

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romainmenke romainmenke merged commit 9e904e1 into main Dec 4, 2023
7 checks passed
@romainmenke romainmenke deleted the css-calc--compassionate-bat-3ad584652a branch December 4, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants