Monorepo #729
Monorepo #729
Conversation
- Initialized lerna - Added universal build scripts Signed-off-by: Henri Beck <[email protected]>
Signed-off-by: Henri Beck <[email protected]>
Signed-off-by: Henri Beck <[email protected]>
|
Fixed snapshot testing |
Signed-off-by: Henri Beck <[email protected]>
|
I don't know why we were building the test files before, but I haven't added that yet. |
|
@HenriBeck we have this tests/index.html, which is using the tmp/tests.js. I think we can get rid of it. The use case was to run tests from a static page, but we can also run it through the local tests server once it is running. It was easy to just open a html file without any server on any browser. |
|
@HenriBeck let me know when to try this out |
|
@kof should be ready to try out |
|
The problem is when we merge any pr, we create conflicts because literally, every file has changed. So if we could move forward before any other PRs are merged it would be great. |
|
oh yeah, sorry for that, we need to merge it asap, I will look into it today |
|
are you available on some chat? in case I have things to discuss |
|
you can just email me at [email protected] or just post it here |
| @@ -7,3 +7,4 @@ lib | |||
| dist | |||
| .env | |||
| coverage | |||
| packages/**/lincense.md | |||
There was a problem hiding this comment.
do we need a license file in each package?
There was a problem hiding this comment.
It just copies it when the build script runs from the root path. I think every npm package should have a LICENSE file, I don't think we lose anything without it.
| @@ -4,4 +4,4 @@ JSS core library is a rendering engine. We aim to make it small, fast and unopin | |||
| It is often too low level for applications. | |||
| That's why there is a bunch of higher level libraries on top of it, which provide more opinionated sugar APIs and framework integrations. | |||
|
|
|||
| [See all projects](./projects.md) | |||
There was a problem hiding this comment.
driveby commits like this making PR larger and harder to merge
| @@ -0,0 +1,40 @@ | |||
| /* eslint-disable no-console */ | |||
There was a problem hiding this comment.
why do we need this file instead of just using those commands directly in npm scripts?
There was a problem hiding this comment.
is it to run those scripts over each package? doesn't lerna has something to do that in a more concise way? any other options?
There was a problem hiding this comment.
No, we would need to install babel-cli for every package, there is no way to use those commands inside npm scripts without installing it inside every package.
That way we only need one script and not have multiple build scripts for every package.
There was a problem hiding this comment.
what about ../../node_modules/.bin/{script}
There was a problem hiding this comment.
Still, we would need a build:lib, build:dist and maybe build:flow script in every package.
I think this one is more maintainable. This approach is also used by storybook.
|
Ok, found again time, working on it. |
|
there are so many questions open that I think we can't make it in one PR and we need to start merging it and iterate |
|
Do we want to have a single version number for all plugins or separate? |
|
merged 🎉 |
|
I think we should have one single version. One single version for the core and the plugins which should make it clear which version you need to install when installing a plugin. |
|
I would start importing the plugins then next. Should find some time on the weekend for that. |
|
yeah, me too, even though react-jss could be a separate version, I think its easier that way |
What is already done:
Still left to do: