Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monorepo #729

Merged
merged 6 commits into from
Jul 5, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
flow-typed/
**/node_modules/**
packages/**/lib/
packages/**/dist/
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ lib
dist
.env
coverage
packages/**/lincense.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need a license file in each package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It just copies it when the build script runs from the root path. I think every npm package should have a LICENSE file, I don't think we lose anything without it.

12 changes: 0 additions & 12 deletions .size-snapshot.json

This file was deleted.

4 changes: 2 additions & 2 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@

## 9.8.4 / 2018-06-12

* Add link to the egghead course
* Upgrade prettier and format code (#726)
- Add link to the egghead course
- Upgrade prettier and format code (#726)

## 9.8.3 / 2018-06-10

Expand Down
2 changes: 1 addition & 1 deletion docs/abstractions.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ JSS core library is a rendering engine. We aim to make it small, fast and unopin
It is often too low level for applications.
That's why there is a bunch of higher level libraries on top of it, which provide more opinionated sugar APIs and framework integrations.

[See all projects](./projects.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby commits like this making PR larger and harder to merge

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

driveby commits?

[See all projects](projects.md)
4 changes: 2 additions & 2 deletions docs/benefits.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

1. **Avoids slow selectors.**

Because JSS rules are collision free, there is no need to write deeply nested selectors. This leads to stable [performance](./performance.md) at scale.
Because JSS rules are collision free, there is no need to write deeply nested selectors. This leads to stable [performance](performance.md) at scale.

1. **Code reuse, expressiveness.**

Expand Down Expand Up @@ -81,7 +81,7 @@

1. **Performance.**

Inline styles are [slower](./performance.md) than class names.
Inline styles are [slower](performance.md) than class names.

## Compared to Radium

Expand Down
4 changes: 2 additions & 2 deletions docs/js-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ You need to have the [jss-global](https://github.com/cssinjs/jss-global) plugin
`SheetsRegistry`

When rendering on the server, you will need to get all rendered styles as a CSS string.
SheetsRegistry class allows you to **manually** aggregate and stringify them. Read [more about SSR](./ssr.md).
SheetsRegistry class allows you to **manually** aggregate and stringify them. Read [more about SSR](ssr.md).

```javascript
import jss, {SheetsRegistry} from 'jss'
Expand Down Expand Up @@ -414,4 +414,4 @@ const dynamicStyles = getDynamicStyles({

## Plugins

See [plugins](./plugins.md) documentation.
See [plugins](plugins.md) documentation.
2 changes: 1 addition & 1 deletion docs/json-api.md
Original file line number Diff line number Diff line change
Expand Up @@ -423,4 +423,4 @@ Compiles to:

## Plugins

JSS plugins give you even more features, [read about them](./plugins.md).
JSS plugins give you even more features, [read about them](plugins.md).
2 changes: 1 addition & 1 deletion docs/setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ jss.setup({

## Configuring Content Security Policy

You might need to set the `style-src` CSP directive, but do not want to set it to `unsafe-inline`. See [these instructions for configuring CSP](./csp.md).
You might need to set the `style-src` CSP directive, but do not want to set it to `unsafe-inline`. See [these instructions for configuring CSP](csp.md).

## CLI

Expand Down
4 changes: 2 additions & 2 deletions karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ module.exports = config => {
'node_modules/es5-shim/es5-shim.js',
'node_modules/es5-shim/es5-sham.js',
'node_modules/css.escape/css.escape.js',
'tests/index.js'
'./packages/jss/tests/index.js'
],
preprocessors: {
'tests/index.js': ['webpack', 'sourcemap']
'./packages/jss/tests/index.js': ['webpack', 'sourcemap']
},
webpack: Object.assign(webpackConfig, {
devtool: 'inline-source-map'
Expand Down
5 changes: 5 additions & 0 deletions lerna.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"lerna": "2.11.0",
"packages": ["packages/*"],
"version": "9.8.7"
}
Loading