Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Jest #745

Open
1 of 3 tasks
kof opened this issue Jul 5, 2018 · 6 comments
Open
1 of 3 tasks

Migrate to Jest #745

kof opened this issue Jul 5, 2018 · 6 comments
Labels
complexity:moderate We talked about it, you can do it!

Comments

@kof
Copy link
Member

kof commented Jul 5, 2018 •
edited by HenriBeck
Loading

Todo
@kof kof added the complexity:moderate We talked about it, you can do it! label Jul 5, 2018
This was referenced Jul 5, 2018
Open
Merged
@HenriBeck
Copy link
Member

The most significant difference is that jest doesn't use it and instead uses test which should be a simple search and replace for migrating most of the tests

@TrySound
Copy link
Member

@HenriBeck Actually it has all describe, it, test.

@HenriBeck
Copy link
Member

Oh, yeah it is an alias of test. Then it's even more simple 👍

@TrySound
Copy link
Member

Rewire conversion is messy. I did it, but can't figure out how to run karma with babel7 for functional tests.

@HenriBeck
Copy link
Member

HenriBeck commented Jul 21, 2018 •
edited
Loading

We could remove rewire when we switch to jest's mocking functionality.

@TrySound
Copy link
Member

I removed and switched. We just need to move out functional tests somewhere and I will push jest tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:moderate We talked about it, you can do it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kof @TrySound @HenriBeck