Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Int64 is not checked in gas related api #425

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Mar 14, 2024

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 63.32%. Comparing base (b216a32) to head (f437aea).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #425   +/-   ##
========================================
  Coverage    63.31%   63.32%           
========================================
  Files          130      130           
  Lines        12342    12342           
========================================
+ Hits          7814     7815    +1     
+ Misses        4014     4013    -1     
  Partials       514      514           
Files Coverage Δ
rpc/backend/backend.go 78.94% <ø> (ø)
rpc/backend/node_info.go 46.97% <100.00%> (+0.46%) ⬆️
rpc/backend/call_tx.go 57.58% <0.00%> (ø)

@mmsqe mmsqe changed the title Problem: base fee is not checked in eth_maxPriorityFeePerGas Problem: Int64 is not checked in gas related api Mar 15, 2024
@mmsqe mmsqe requested a review from yihuang March 15, 2024 01:21
rpc/backend/node_info.go Outdated Show resolved Hide resolved
rpc/backend/chain_info.go Outdated Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge (squash) March 15, 2024 02:11
@mmsqe mmsqe merged commit c39e892 into crypto-org-chain:develop Mar 15, 2024
37 of 39 checks passed
@yihuang yihuang deleted the check_base_fee branch March 15, 2024 02:11
yihuang added a commit that referenced this pull request Mar 15, 2024
* Problem: Int64 is not checked in gas related api

* Apply suggestions from code review

* revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants