Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Int64 is not checked in gas related api (backport #425) #426

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 15, 2024

  • Problem: Int64 is not checked in gas related api

  • Apply suggestions from code review

  • revert

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe March 15, 2024 07:57
* Problem: Int64 is not checked in gas related api

* Apply suggestions from code review

* revert
@yihuang yihuang force-pushed the release/v0.21.x-cronos branch from f54a2b6 to 580bd61 Compare March 15, 2024 08:00
@yihuang yihuang merged commit 426480e into crypto-org-chain:release/v0.21.x-cronos Mar 15, 2024
29 of 30 checks passed
@yihuang yihuang deleted the release/v0.21.x-cronos branch March 15, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants