Skip to content

Commit

Permalink
Problem: base fee is not checked in eth_maxPriorityFeePerGas
Browse files Browse the repository at this point in the history
  • Loading branch information
mmsqe committed Mar 14, 2024
1 parent 70f88bf commit fd9e4ae
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
- (evm) [#405](https://github.com/crypto-org-chain/ethermint/pull/405) Avoid duplicate cache events emitted from evm hooks.
- (rpc) [#406](https://github.com/crypto-org-chain/ethermint/pull/406) Align filter rule for eth_getLogs when toBlock is newer than latest or extract error occurs.
- (rpc) [#409](https://github.com/crypto-org-chain/ethermint/pull/409) Fix nextBaseFee in eth_feeHistory before fee market param change.
- (rpc) [#](https://github.com/crypto-org-chain/ethermint/pull/) Check baseFee in eth_maxPriorityFeePerGas.

### Improvements

Expand Down
2 changes: 1 addition & 1 deletion rpc/backend/chain_info.go
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ func (b *Backend) FeeHistory(
// Although we don't support tx prioritization yet, but we return a positive value to help client to
// mitigate the base fee changes.
func (b *Backend) SuggestGasTipCap(baseFee *big.Int) (*big.Int, error) {
if baseFee == nil {
if baseFee == nil || !baseFee.IsInt64() {
// london hardfork not enabled or feemarket not enabled
return big.NewInt(0), nil
}
Expand Down

0 comments on commit fd9e4ae

Please sign in to comment.