Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[SIMD] Fix d8 crashes when constructing simd128 typed array without simd... #14

Merged
merged 1 commit into from
Mar 31, 2014
Merged

[SIMD] Fix d8 crashes when constructing simd128 typed array without simd... #14

merged 1 commit into from
Mar 31, 2014

Conversation

huningxin
Copy link
Contributor

... flag

The simd128 typed array constructors should be guarded by simd-object
runtime flag.

BUG=https://crosswalk-project.org/jira/browse/XWALK-1250

@huningxin
Copy link
Contributor Author

Cherry-pick from master. @fenghaitao, Please review. Thanks.

@fenghaitao
Copy link
Contributor

lgtm

@rakuco
Copy link

rakuco commented Mar 26, 2014

Please use git cherry-pick -x to indicate the hash of the original commit in master so we can easily trace it back.

@huningxin
[SIMD] Fix d8 crashes when constructing simd128 typed array without s…
f4d82d2 
…imd flag

The simd128 typed array constructors should be guarded by simd-object
runtime flag.

BUG=https://crosswalk-project.org/jira/browse/XWALK-1250
(cherry picked from commit 3f182b6)
@huningxin
Copy link
Contributor Author

Done. @rakuco , please take another look. Thanks.

rakuco pushed a commit that referenced this pull request Mar 31, 2014
Merge pull request #14 from huningxin/crosswalk-5/34.0.1847.45
329b763 
[SIMD] Fix d8 crashes when constructing simd128 typed array without simd...
@rakuco rakuco merged commit 329b763 into crosswalk-project:crosswalk-5/34.0.1847.45 Mar 31, 2014
@rakuco
Copy link

rakuco commented Mar 31, 2014

Merged. Please remember to roll crosswalk-5's DEPS.xwalk.

mrunalk pushed a commit to mrunalk/v8-crosswalk that referenced this pull request Feb 5, 2015
@bmeurer
Version 4.1.0.13 (cherry-pick)
bfe7179 
Merged 9e99a60

Fix run-time ARMv6 detection.

BUG=v8:3844
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/866393002

Cr-Commit-Position: refs/branch-heads/4.1@{crosswalk-project#14}
Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}
Bysmyyr pushed a commit to Bysmyyr/v8-crosswalk that referenced this pull request Apr 2, 2015
@verwaest
Version 4.2.77.13 (cherry-pick)
0d2d0e5 
Merged 0f57346

Ensure we don't overflow in BCE

BUG=chromium:469148
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/997153005

Cr-Commit-Position: refs/branch-heads/4.2@{crosswalk-project#14}
Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{crosswalk-project#2}
Cr-Branched-From: e011092-refs/heads/master@{#26757}
rakuco pushed a commit that referenced this pull request Apr 30, 2015
@jakobkummerow
Version 4.3.61.11 (cherry-pick)
baf880d 
Merged 434b456

Fix indirect push

BUG=chromium:388665
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1072403011

Cr-Commit-Position: refs/branch-heads/4.3@{#14}
Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1}
Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}
cdai2 pushed a commit to cdai2/v8-crosswalk that referenced this pull request Jun 4, 2015
Revert of Clean up aligned allocation code in preparation for SIMD al…
3ee926e 
…ignments. (patchset crosswalk-project#14 id:300001 of https://codereview.chromium.org/1150593003/)

Reason for revert:
Breaks mjsunit, webkit, mozilla, benchmarks.

[email protected]

Original issue's description:
> Clean up aligned allocation code in preparation for SIMD alignments.
>
> Moves alignment fill calculations into two static Heap methods.
> Adds a Heap method to handle the complex case where filler is potentially needed before and after a heap object.
> Makes DoubleAlignForDeserialization explicitly fill after an already
> aligned object.
>
> LOG=N
> BUG=v8:4124
>
> Committed: https://crrev.com/fcfb080eb9a637f0ae066bed4c45095e60df8a84
> Cr-Commit-Position: refs/heads/master@{#28687}

[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:4124

Review URL: https://codereview.chromium.org/1159123002

Cr-Commit-Position: refs/heads/master@{#28688}
rakuco pushed a commit that referenced this pull request Jul 14, 2015
@isheludko
Version 4.4.63.10 (cherry-pick)
bc3ef49 
Merged 4742176

Map::ReconfigureProperty() should mark map as unstable when it returns a different map.

BUG=chromium:502930
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1217473003.

Cr-Commit-Position: refs/branch-heads/4.4@{#14}
Cr-Branched-From: 2e4c550-refs/heads/4.4.63@{#1}
Cr-Branched-From: 0208b8e-refs/heads/master@{#28333}
rakuco pushed a commit that referenced this pull request Aug 5, 2015
@natorion
Fix v8/test/mjsunit/big-array-literal.js
999a1ff 
[email protected], [email protected], [email protected]
BUG=v8:4319
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1248983003

Cr-Commit-Position: refs/branch-heads/4.5@{#14}
Cr-Branched-From: 7f21153-refs/heads/4.5.103@{#1}
Cr-Branched-From: 4b38c15-refs/heads/master@{#29527}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
@natorion
Fix version file
4e82baa 
Will be tagged after commit.

BUG=v8:4398
[email protected]
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1323983003

Cr-Commit-Position: refs/branch-heads/4.6@{#14}
Cr-Branched-From: 24d34a8-refs/heads/4.6.85@{#1}
Cr-Branched-From: 8f44118-refs/heads/master@{#30256}
rakuco pushed a commit that referenced this pull request Jan 13, 2016
@natorion
Version 4.8.271.11 (cherry-pick)
efc5cbb 
Merged fa13da2

[stubs] Fix TypeOfStub to properly return "undefined" for undetectable.

BUG=chromium:567998
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1546903002 .

Cr-Commit-Position: refs/branch-heads/4.8@{#14}
Cr-Branched-From: 10449d4-refs/heads/4.8.271@{#1}
Cr-Branched-From: 2ebd5fc-refs/heads/master@{#31941}
nerdmed pushed a commit to nerdmed/v8-crosswalk that referenced this pull request Jan 20, 2016
@otherdaniel
Revert of Implement Fast Accessor Builder (patchset crosswalk-project#14
0a50af8 
 id:260001 of https://codereview.chromium.org/1474543004/ )

Reason for revert:
Broke the build, apparently.

Original issue's description:
> Implement FastAccessorBuilder.
>
> ... using the RawMachineAssembler and the work in cl/1407313004
>
> BUG=chromium:508898
> LOG=Y
>
> Committed: https://crrev.com/515d9ccd8e6df7bf2ca01e2a55aaad30226399e1
> Cr-Commit-Position: refs/heads/master@{#32742}

[email protected],[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:508898

Review URL: https://codereview.chromium.org/1513203002

Cr-Commit-Position: refs/heads/master@{#32744}
nerdmed pushed a commit to nerdmed/v8-crosswalk that referenced this pull request Jan 20, 2016
@bmeurer
Revert of [runtime] Introduce dedicated JSBoundFunction to represent …
1cf8b10 
…bound functions. (patchset crosswalk-project#14 id:260001 of https://codereview.chromium.org/1542963002/ )

Reason for revert:
Breaks arm64 sim nosnap: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/805/steps/Check/logs/function-bind

Original issue's description:
> [runtime] Introduce dedicated JSBoundFunction to represent bound functions.
>
> According to the ES2015 specification, bound functions are exotic
> objects, and thus don't need to be implemented as JSFunctions. So
> we introduce a new JSBoundFunction type to represent bound functions
> and make them optimizable. This already improves the performance of
> calling or constructing bound functions by 10-100x depending on the
> use case because we avoid the crazy dance between JavaScript and C++
> that was implemented in v8natives.js previously.
>
> There's still room for improvement in the performance of actually
> creating bound functions, which is also relevant in practice, but
> we already have a plan how to accomplish that later.
>
> The mips/mips64 ports were contributed by [email protected].
>
> CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel
> BUG=chromium:535408, chromium:571299, v8:4629
> LOG=n
>
> Committed: https://crrev.com/ca8623eaa468cba65a5adafcdfb4615966f43ce2
> Cr-Commit-Position: refs/heads/master@{#33042}

[email protected],[email protected],[email protected],[email protected]
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:535408, chromium:571299, v8:4629

Review URL: https://codereview.chromium.org/1552473002

Cr-Commit-Position: refs/heads/master@{#33043}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
@jeisinger
Version 4.9.385.12 (cherry-pick)
5c612e7 
Merged 85f32f1

Don't NULL-check GlobalHandle::Node::object_

BUG=chromium:580651,v8:3647
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1643713004 .

Cr-Commit-Position: refs/branch-heads/4.9@{#14}
Cr-Branched-From: 2fea296-refs/heads/4.9.385@{#1}
Cr-Branched-From: 0c1430a-refs/heads/master@{#33306}
mrunalk pushed a commit that referenced this pull request Apr 5, 2016
@natorion
Version 5.0.71.2 (cherry-pick)
c30d63e 
Merged 9146bc5

Revert of Replace slots buffer with remembered set. (patchset #14 id:250001 of https://codereview.chromium.org/1703823002/ )

BUG=chromium:578883
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1739003003 .

Cr-Commit-Position: refs/branch-heads/5.0@{#3}
Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
mrunalk pushed a commit that referenced this pull request Apr 5, 2016
Revert of Version 5.0.71.10 (cherry-pick) (patchset #1 id:1 of https:…
d5cf399 
…//codereview.chromium.org/1777503002/ )

Reason for revert:
This makes "mjsunit/undetectable-compare" fail, some previous drive-by-fix might be missing from the branch that allows us to make the switch away from the CompareIC. This is no longer a quick-fix that can be merged back and we are essentially flying blind on the branch. I am no longer confident that the quick-fix can be merged back. Reverting.

Original issue's description:
> Version 5.0.71.10 (cherry-pick)
>
> Merged 55b4df7
> Merged d00da47
> Merged 4da2e3d
> Merged c1507e1
>
> [runtime] Unify comparison operator runtime entries.
>
> [turbofan] Don't use the CompareIC in JSGenericLowering.
>
> PPC: [runtime] Unify comparison operator runtime entries.
>
> PPC: [turbofan] Don't use the CompareIC in JSGenericLowering.
>
> [email protected]
> BUG=chromium:590832,v8:4788
> LOG=N
>
> Committed: https://chromium.googlesource.com/v8/v8/+/0843a173996f5f63eca749d6fe8c20d4813537d9

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:590832,v8:4788

Review URL: https://codereview.chromium.org/1775883003

Cr-Commit-Position: refs/branch-heads/5.0@{#14}
Cr-Branched-From: ad16e6c-refs/heads/5.0.71@{#1}
Cr-Branched-From: bd9df50-refs/heads/master@{#34215}
mrunalk pushed a commit that referenced this pull request May 20, 2016
@ulan
Revert of Replace slots buffer with remembered set. (patchset #14 id:…
9146bc5 
…250001 of https://codereview.chromium.org/1703823002/ )

Reason for revert:
Revert because of canary crashes: crbug.com/589413

Original issue's description:
> Replace slots buffer with remembered set.
>
> Slots pointing to evacuation candidates are now recorded in the new RememberedSet<OLD_TO_OLD>.
>
> The remembered set is extended to support typed slots.
>
> During parallel evacuation all migration slots are recorded in local slots buffers.
> After evacuation all local slots are added to the remembered set.
>
> BUG=chromium:578883
> LOG=NO
>
> Committed: https://crrev.com/2285a99ef6f7d52f4f0c4d88a7db4224443ee152
> Cr-Commit-Position: refs/heads/master@{#34212}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:578883

Review URL: https://codereview.chromium.org/1725073003

Cr-Commit-Position: refs/heads/master@{#34238}
mrunalk pushed a commit that referenced this pull request May 20, 2016
@ulan
Reland "Replace slots buffer with remembered set. (patchset #14 id:25…
01b8fc8 
…0001 of https://codereview.chromium.org/1703823002/ )"

This reverts commit 9146bc5.

This contains a fix for the following crash:
1. We record slots for a fixed array.
2. We trim the fixed array, so that some recorded slots are now in free space.
3. During mark-compact we sweep the page with the fixed array. Now free list items contain memory with recorded slots.
4. We evacuate a byte array using the new free list items.
5. We iterate slots that are now inside the byte array and crash.

BUG=chromium:589413,chromium:578883
LOG=NO

Review URL: https://codereview.chromium.org/1735523002

Cr-Commit-Position: refs/heads/master@{#34302}
mrunalk pushed a commit that referenced this pull request May 20, 2016
@camillobruni
Revert of [key-accumulator] Starting to reimplement the key-accumulat…
18db9af 
…or (patchset #14 id:260001 of https://codereview.chromium.org/1707743002/ )

Reason for revert:
gcmole failure https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8598

Original issue's description:
> [key-accumulator] Starting to reimplement the key-accumulator
>
> Introducing the KeyAccumulator accidentally removed some crucial fast-paths.
> This CL starts rewriting the KeyAccumulator, step-by-step introducing the
> special cases again.
>
> BUG=chromium:545503, v8:4758
> LOG=y
>
> Committed: https://crrev.com/9c61327ecb2ee41f34232632e0cac93202bae6b7
> Cr-Commit-Position: refs/heads/master@{#34532}

[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:545503, v8:4758

Review URL: https://codereview.chromium.org/1773593003

Cr-Commit-Position: refs/heads/master@{#34537}
mrunalk pushed a commit that referenced this pull request May 20, 2016
@hashseed
Revert of [compiler] Add relocatable pointer constants for wasm memor…
2069ab2 
…y references. (patchset #14 id:300001 of https://codereview.chromium.org/1759383003/ )

Reason for revert:
Test failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/8046

Original issue's description:
> [compiler] Add relocatable pointer constants for wasm memory references.
>
> Add relocatable pointers for wasm memory references that need to be updated when wasm GrowMemory is used. Code generator changes to accept relocatable constants as immediates.
>
> [email protected], [email protected], [email protected]
>
> Committed: https://crrev.com/eb5fe0df64ec0add423b2a1f6fb62d5a33dce2a5
> Cr-Commit-Position: refs/heads/master@{#35182}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1846083005

Cr-Commit-Position: refs/heads/master@{#35185}
mrunalk pushed a commit that referenced this pull request May 20, 2016
@ajklein
Version 5.1.281.11 (cherry-pick)
50c7f87 
Merged 9acbca1

[es6] Fix bug in pattern re-writing

BUG=v8:4891
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/1903153004 .

Cr-Commit-Position: refs/branch-heads/5.1@{#14}
Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mrunalk pushed a commit that referenced this pull request Jun 21, 2016
Version 5.2.361.9
940ef3d 
Cr-Commit-Position: refs/branch-heads/5.2@{#14}
Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1}
Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}
mrunalk pushed a commit that referenced this pull request Aug 10, 2016
@jaro-sevcik
Version 5.3.332.11 (cherry-pick)
26a5d7a 
Merged 7614362

[turbofan] Set elements kind to holey if constructing array of possibly non-zero length.

BUG=chromium:621147
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/2131003003 .

Cr-Commit-Position: refs/branch-heads/5.3@{#14}
Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2}
Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
mrunalk pushed a commit that referenced this pull request Sep 27, 2016
Version 5.4.500.8
3807927 
Cr-Commit-Position: refs/branch-heads/5.4@{#14}
Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2}
Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto pushed a commit to tenta-browser/v8-crosswalk that referenced this pull request Sep 4, 2017
Version 5.9.211.5
7806158 
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#14}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam pushed a commit to asifhisam/v8-crosswalk that referenced this pull request Sep 9, 2019
Version 5.8.283.6
794066e 
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#14}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huningxin @fenghaitao @rakuco