Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[SIMD] Fix d8 crashes when constructing simd128 typed array without simd... #14

Merged
merged 1 commit into from
Mar 31, 2014
Merged

[SIMD] Fix d8 crashes when constructing simd128 typed array without simd... #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/bootstrapper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ void Genesis::InitializeGlobal(Handle<GlobalObject> inner_global,
EXTERNAL_##TYPE##_ELEMENTS); \
native_context()->set_##type##_array_fun(*fun); \
}
TYPED_ARRAYS(INSTALL_TYPED_ARRAY)
BUILTIN_TYPED_ARRAY(INSTALL_TYPED_ARRAY)
#undef INSTALL_TYPED_ARRAY

Handle<JSFunction> data_view_fun =
Expand Down
13 changes: 10 additions & 3 deletions src/objects.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4670,7 +4670,7 @@ class FreeSpace: public HeapObject {


// V has parameters (Type, type, TYPE, C type, element_size)
#define TYPED_ARRAYS(V) \
#define BUILTIN_TYPED_ARRAY(V) \
V(Uint8, uint8, UINT8, uint8_t, 1) \
V(Int8, int8, INT8, int8_t, 1) \
V(Uint16, uint16, UINT16, uint16_t, 2) \
Expand All @@ -4679,11 +4679,18 @@ class FreeSpace: public HeapObject {
V(Int32, int32, INT32, int32_t, 4) \
V(Float32, float32, FLOAT32, float, 4) \
V(Float64, float64, FLOAT64, double, 8) \
V(Float32x4, float32x4, FLOAT32x4, v8::internal::float32x4_value_t, 16) \
V(Int32x4, int32x4, INT32x4, v8::internal::int32x4_value_t, 16) \
V(Uint8Clamped, uint8_clamped, UINT8_CLAMPED, uint8_t, 1)


#define SIMD128_TYPED_ARRAY(V) \
V(Float32x4, float32x4, FLOAT32x4, v8::internal::float32x4_value_t, 16) \
V(Int32x4, int32x4, INT32x4, v8::internal::int32x4_value_t, 16)


#define TYPED_ARRAYS(V) \
BUILTIN_TYPED_ARRAY(V) \
SIMD128_TYPED_ARRAY(V)


// An ExternalArray represents a fixed-size array of primitive values
// which live outside the JavaScript heap. Its subclasses are used to
Expand Down