This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Optimize Float32x4Array and Int32x4Array element loading and storing #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
There was a problem hiding this comment.
Looks better in the code with this new line.
|
Complete 1st round code review. Thanks. |
|
All comments are addressed. IA32 port is done. I also added deoptimization into this patch set as otherwise we could not run the SIMD benchmarks. This optimization is not done for ARM yet as ARM SIMD128 registers are different than double registers. Please take another look. |
| @@ -121,6 +139,129 @@ class OptimizedFunctionVisitor BASE_EMBEDDED { | |||
| }; | |||
|
|
|||
|
|
|||
| class TranslationBuffer BASE_EMBEDDED { | |||
There was a problem hiding this comment.
Why re-implement this class other than add SIMD stuff into it.?
There was a problem hiding this comment.
This class is moved up as we want to use Translation::Opcode definition in the AddSIMD128Value method of the deoptimizer class.
There was a problem hiding this comment.
Changed the interface to AddObjectSIMD128Value(simd128_value_t value, int translation_code) to avoid moving this class up to make rebasing a little bit easier in the future.
|
Optimization of array element loading part LGTM. |
|
The deoptimization part LGTM. Thanks. |
fenghaitao
added a commit
that referenced
this pull request
Mar 7, 2014
Optimize Float32x4Array and Int32x4Array element loading and storing
ia32 and x64 port by: 1). Allocating SIMD128 registers 2). Emitting SIMD movups instruction 3). Adding deoptimization support for SIMD128 registers or stack slots
rakuco
pushed a commit
that referenced
this pull request
Jan 15, 2015
BUG=chromium:318206 LOG=y [email protected] Review URL: https://codereview.chromium.org/839203002 Cr-Commit-Position: refs/branch-heads/4.1@{#3} Cr-Branched-From: 2e08d2a-refs/heads/candidates@{#25353}
rakuco
pushed a commit
that referenced
this pull request
Mar 12, 2015
This ports https://codereview.chromium.org/959713003/ to the 4.2 branch. BUG=v8:3075 LOG=n [email protected] Review URL: https://codereview.chromium.org/953363002 Cr-Commit-Position: refs/branch-heads/4.2@{#3} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}
darktears
pushed a commit
that referenced
this pull request
Mar 23, 2015
…patchset #3 id:40001 of https://codereview.chromium.org/955063002/) Reason for revert: Breaks test/mjsunit/debug-clearbreakpointgroup.js on arm64.debug. Original issue's description: > Fix memory leak caused by field type in descriptor array. > > When a field type is a map, it is wrapped in a weak cell upon storing to the descriptor array. > > Map::GetFieldType(i) does the unwrapping. > > BUG=v8:3877 > LOG=N > TEST=cctest/test-heap/Regress3877 > > Committed: https://crrev.com/77d3ae0e119893ac8d34ea6ca090cddd5bbf987e > Cr-Commit-Position: refs/heads/master@{#26879} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3877 Review URL: https://codereview.chromium.org/960103003 Cr-Commit-Position: refs/heads/master@{#26883}
darktears
pushed a commit
that referenced
this pull request
Mar 23, 2015
…://codereview.chromium.org/962263002/) Reason for revert: Fails on nosnap build Original issue's description: > Disallow subclassing Arrays. > > [email protected],[email protected] > BUG=v8:3930 > LOG=Y > > Committed: https://crrev.com/87f3e08e72510ee5544e82bb7ad39b2b5f001ad3 > Cr-Commit-Position: refs/heads/master@{#26925} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3930 Review URL: https://codereview.chromium.org/965053002 Cr-Commit-Position: refs/heads/master@{#26930}
darktears
pushed a commit
that referenced
this pull request
Mar 23, 2015
…set #3 id:100001 of https://codereview.chromium.org/976203003/) Reason for revert: Some tests still flaky Original issue's description: > CpuProfiler: enable tests except four failing tests. > > Four tests are failing due to a problem with no frame ranges. > > BUG= > LOG=n > > Committed: https://crrev.com/2be160e726f2be6272b77e53fbd556aded6024f1 > Cr-Commit-Position: refs/heads/master@{#27035} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/987553005 Cr-Commit-Position: refs/heads/master@{#27037}
darktears
pushed a commit
that referenced
this pull request
Mar 25, 2015
…he StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} [email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Review URL: https://codereview.chromium.org/1004623003 Cr-Commit-Position: refs/heads/master@{#27207}
darktears
pushed a commit
that referenced
this pull request
Apr 10, 2015
#3 id:40001 of https://codereview.chromium.org/1014813003/) Reason for revert: Layout test failures. Please update layout test expectations before landing this, in order to not block the roll. Original issue's description: > [es6] Object.getPrototypeOf should work with values > > The final spec for Object.getPrototypeOf calls ToObject on the > parameter, which means that it should only throw for null and > undefined. For other non object values the prototype of the wrapper > should be used. > > BUG=v8:3964 > LOG=N > R=adamk, [email protected] > > Committed: https://crrev.com/ea463a916bbe5994b0d2d04e8075058b373b2e2c > Cr-Commit-Position: refs/heads/master@{#27354} [email protected],[email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3964 Review URL: https://codereview.chromium.org/1033623002 Cr-Commit-Position: refs/heads/master@{#27389}
darktears
pushed a commit
that referenced
this pull request
Apr 10, 2015
…https://codereview.chromium.org/1022333004/) Reason for revert: [Sheriff] This seems to change layout test expectations of some tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064%20%28dbg%29/builds/2317 Expectation example: https://storage.googleapis.com/chromium-layout-test-archives/V8-Blink_Linux_64__dbg_/2317/layout-test-results/fast/events/window-onerror-11-pretty-diff.html Please add a needsmanualrebaseline expectation to the tests affected by this change on the blink side first before relanding. Original issue's description: > [V8] Removed SourceLocationRestrict > > This method uses in messages.js in GetSourceLine and GetPositionInLine. This methods uses in v8::Message API methods and there is no documentation about it. > Method looks obsolete. > One of the strange side effect is shown by attached issue. > > BUG=chromium:468781 > [email protected] > LOG=Y > > Committed: https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf > Cr-Commit-Position: refs/heads/master@{#27374} [email protected],[email protected] NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468781 Review URL: https://codereview.chromium.org/1028413002 Cr-Commit-Position: refs/heads/master@{#27398}
darktears
pushed a commit
that referenced
this pull request
Apr 10, 2015
Merged 00477a5 Ensure that GC idle notifications either make progress or stop requesting more GCs. BUG=chromium:470615 LOG=N [email protected] Review URL: https://codereview.chromium.org/1071503002 Cr-Commit-Position: refs/branch-heads/4.3@{#3} Cr-Branched-From: f5c0a23-refs/heads/4.3.61@{#1} Cr-Branched-From: 0a7d4f4-refs/heads/master@{#27508}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…cessors. (patchset #3 id:40001 of https://codereview.chromium.org/2042013003/ )" This reverts commit d3a43e4. This patch also adds typed_array_fun and typed_array_protoype to the native context. These are used in InstallTypedArray to set up the prototype chain correctly for each typed array sub class. This removes the need to later monkey patch them prototype chain in typedarray.js. This mechanism is also used to get hold of the TypedArray in typedarray.js, removing the need for a global TypedArray. This patch updates CallRuntime.golden to account for the two extra native runtime calls. This patch also fixes some formatting issues (by running git cl format). BUG=chromium:579905, chromium:593634, v8:4085, v8:5073 Review-Url: https://codereview.chromium.org/2046333002 Cr-Commit-Position: refs/heads/master@{#36811}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…atchset #3 id:40001 of https://codereview.chromium.org/2059113002/ ) Reason for revert: compile failure Original issue's description: > [regexp] implement \p{Any}, \p{Ascii}, and \p{Assigned}. > > [email protected], [email protected] > BUG=v8:4743 > > Committed: https://crrev.com/92bfd13457c80f02be01551f4ea9a5badfe0e4c4 > Cr-Commit-Position: refs/heads/master@{#36969} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4743 Review-Url: https://codereview.chromium.org/2065083002 Cr-Commit-Position: refs/heads/master@{#36970}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…ntrinsic bytecode. (patchset #3 id:40001 of https://codereview.chromium.org/2084623002/ ) Reason for revert: [Sheriff] Breaks gc stress: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/6304 Original issue's description: > [Interpreter] Map runtime id's to intrinsic id's in InvokeIntrinsic bytecode. > > Make intrinsic ids a contiguous set of ids so that the switch statement can build > a table switch rather than doing a large if/else tree. > > BUG=v8:4822 > LOG=N > > Committed: https://crrev.com/36abd28a8d9932eb55d7c2bf3ad5e7cfe3eb99ea > Cr-Commit-Position: refs/heads/master@{#37135} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4822 Review-Url: https://codereview.chromium.org/2085823003 Cr-Commit-Position: refs/heads/master@{#37137}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…001 of https://codereview.chromium.org/2083863004/ ) Reason for revert: Many build bots are failing with a message of the form: Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json Can be relanded once we understand why these failures are occuring. Original issue's description: > Include file names in trace_turbo output > > The trace turbo output will overwrite itself when functions in different > files share the same name. Output files now have the form > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`. > > [email protected] > BUG= > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba > Cr-Commit-Position: refs/heads/master@{#37199} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2083153004 Cr-Commit-Position: refs/heads/master@{#37204}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…new-space objects. (patchset #3 id:40001 of https://codereview.chromium.org/2091733002/ ) Reason for revert: This breaks gc-stress bot: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot # # Fatal error in ../../src/heap/mark-compact.cc, line 3715 # Check failed: Page::FromAddress(reinterpret_cast<HeapObject*>(*slot)->address()) ->IsFlagSet(Page::PAGE_NEW_NEW_PROMOTION). # I can reproduce locally, and local revert also fixes it -> revert. Reproduce with: out/Debug/d8 --test --random-seed=2140216864 --nohard-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --allow-natives-syntax --harmony-tailcalls test/mjsunit/mjsunit.js test/mjsunit/es6/tail-call-megatest-shard2.js --gc-interval=500 --stress-compaction --concurrent-recompilation-queue-length=64 --concurrent-recompilation-delay=500 --concurrent-recompilation (Maybe run in loop; it's flaky when broken; but passes reliably w/ revert.) Original issue's description: > Reland [heap] Avoid the use of cells to point from code to new-space objects. > > The reason for reverting was: [Sheriff] Breaks arm debug: > https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/builds/1038. > > The problem was the dereferencing of handles for smi checks. It turned out > that these smi checks can be removed anyways, both on arm and on mips. > > Additionally some rebasing was necessary. > > Original issue's description: > > Cells were needed originally because there was no typed remembered set to > record direct pointers from code space to new space. A previous > CL (https://codereview.chromium.org/2003553002/) already introduced > the remembered set, this CL uses it. > > This CL > * stores direct pointers in code objects, even if the target is in new space, > * records the slot of the pointer in typed-old-to-new remembered set, > * adds a list which stores weak code-to-new-space references, > * adds a test to test-heap.cc for weak code-to-new-space references, > * removes prints in tail-call-megatest.js > > [email protected] > > Committed: https://crrev.com/5508e16592522658587da71ba6743c8e832fe4d1 > Cr-Commit-Position: refs/heads/master@{#37217} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2090983002 Cr-Commit-Position: refs/heads/master@{#37221}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
…tives for all (patchset #3 id:40001 of https://codereview.chromium.org/2096873002/ ) Reason for revert: [Sheriff] Breaks layout tests. Please rebase upstream if intended: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7691 Original issue's description: > Amends the TypedArray constructor to use the path for primitives for all > types of primitives, not just undefined, booleans, numbers, and strings. > (The missing cases were null and Symbol.) This is required by the > specification, and there are test262 tests which we were failing due to > this bug. > > BUG=v8:5124 > > Committed: https://crrev.com/f788bd9cce19815cba746e47bb65abfe25c16208 > Cr-Commit-Position: refs/heads/master@{#37234} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5124 Review-Url: https://codereview.chromium.org/2091693004 Cr-Commit-Position: refs/heads/master@{#37236}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
https://codereview.chromium.org/2083153004/ ) Reason for revert: Ready to test fix and reland. Original issue's description: > Revert of Include file names in trace_turbo output (patchset #3 id:40001 of https://codereview.chromium.org/2083863004/ ) > > Reason for revert: > Many build bots are failing with a message of the form: > > Missing or invalid v8 JSON file: /tmp/tmp2qcEUy_swarming/0/output.json > > Can be relanded once we understand why these failures are occuring. > > Original issue's description: > > Include file names in trace_turbo output > > > > The trace turbo output will overwrite itself when functions in different > > files share the same name. Output files now have the form > > `turbo-<function_name>:<opt_file_name>-<opt_phase>.suffix`. > > > > [email protected] > > BUG= > > > > Committed: https://crrev.com/a53b9bf02f31e5647c37e0392afa19f74df1a3ba > > Cr-Commit-Position: refs/heads/master@{#37199} > > [email protected],[email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG= > > Committed: https://crrev.com/97c2bc362f234bd58515a0faf6af23b4f8ad183a > Cr-Commit-Position: refs/heads/master@{#37204} [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2081323007 Cr-Commit-Position: refs/heads/master@{#37303}
mrunalk
pushed a commit
that referenced
this pull request
Aug 10, 2016
This reverts commit 820a23a. I am removing the instrumentation from the release branch as discussed. [email protected],[email protected],[email protected],[email protected] Review URL: https://codereview.chromium.org/2119443002 . Cr-Commit-Position: refs/branch-heads/5.3@{#3} Cr-Branched-From: 820a23a-refs/heads/5.3.332@{#2} Cr-Branched-From: 37538cb-refs/heads/master@{#37308}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…//codereview.chromium.org/2103713003/ ) Reason for revert: Causes "buildbot failure in V8 on V8 Linux gcc 4.8, Check" Original issue's description: > [ia32] Fixes a bug in cmpw. > > The opcodes for 'cmpw r/m16, r16' and 'cmpw r16, r/m16' were swapped, causing a few issues when less than/greater than comparison were performed. > > Adds a regression test. > > BUG=621926 > > Committed: https://crrev.com/efa7095e3e360fbadbe909d831ac11b268ca26b0 > Cr-Commit-Position: refs/heads/master@{#37339} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=621926 Review-Url: https://codereview.chromium.org/2106913002 Cr-Commit-Position: refs/heads/master@{#37342}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…https://codereview.chromium.org/2122933002/ ) Reason for revert: Breaks test isolation on shared library bot. Original issue's description: > [gn] Switch more linux32 bots to gn > > This switches nosnap and shared library bots to gn. > > This also unsets external startup data if no snapshot is > used. > > BUG=chromium:474921 > NOTRY=true > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > Cr-Commit-Position: refs/heads/master@{#37546} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2128493002 Cr-Commit-Position: refs/heads/master@{#37548}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…tps://codereview.chromium.org/2128493002/ ) Reason for revert: Should be fixed after https://codereview.chromium.org/2123223002/ Original issue's description: > Revert of [gn] Switch more linux32 bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2122933002/ ) > > Reason for revert: > Breaks test isolation on shared library bot. > > Original issue's description: > > [gn] Switch more linux32 bots to gn > > > > This switches nosnap and shared library bots to gn. > > > > This also unsets external startup data if no snapshot is > > used. > > > > BUG=chromium:474921 > > NOTRY=true > > > > Committed: https://crrev.com/ab4d8fc07d9d35e6fc129098f42aa0317a02244a > > Cr-Commit-Position: refs/heads/master@{#37546} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/a5fa2984257a50ee9440914c7d1a199f64a86194 > Cr-Commit-Position: refs/heads/master@{#37548} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2126843002 Cr-Commit-Position: refs/heads/master@{#37558}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…/codereview.chromium.org/2124263002/ ) Reason for revert: There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068 Original issue's description: > [gn] Switch gcc bots to gn > > BUG=chromium:474921 > > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 > Cr-Commit-Position: refs/heads/master@{#37580} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2130303002 Cr-Commit-Position: refs/heads/master@{#37603}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
id:40001 of https://codereview.chromium.org/2102063002/ ) Reason for revert: This workaround is no longer needed, port of e60c405 fixes the issue. Original issue's description: > MIPS: [turbofan] Fix addition for deoptimization. > > In turbofan, after an addition operation where the same register is the > output and both inputs, if deoptimization is performed the input is > overwritten with the output value and the final result is not correct. > This is fixed by restoring the original value of the input before > deoptimization. > > BUG= > TEST=mjsunit/regress/regress-int32-truncation > > Committed: https://crrev.com/99385e8e4bcef1f333ede61c936528bfc0c8ecfa > Cr-Commit-Position: refs/heads/master@{#37524} [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2129083003 Cr-Commit-Position: refs/heads/master@{#37612}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…ereview.chromium.org/2130303002/ ) Reason for revert: Relanding as the goma problem is due to an upgrade of the binutils version we use. Original issue's description: > Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ ) > > Reason for revert: > There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. > > https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068 > > Original issue's description: > > [gn] Switch gcc bots to gn > > > > BUG=chromium:474921 > > > > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 > > Cr-Commit-Position: refs/heads/master@{#37580} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:474921 > > Committed: https://crrev.com/980d0d6e227f8de3cc0b71a0d3f492908adcf138 > Cr-Commit-Position: refs/heads/master@{#37603} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:474921 NOTRY=true Review-Url: https://codereview.chromium.org/2132333002 Cr-Commit-Position: refs/heads/master@{#37624}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…MD on windows (patchset #3 id:40001 of https://codereview.chromium.org/2149963002/ ) Reason for revert: Fails gyp build with chromium: https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/37051 Blocks roll: https://codereview.chromium.org/2157903002/ Please add the trybot ios-simulator on reland. Original issue's description: > [build] Add force_dynamic_crt option to build a static library with /MD on windows > > Adds option to build a V8 library statically, but with the options on > windows that allows it to be subsequently included in another DLL. On > Windows this is required for it to correclty link against the correct > C++ runtime. Require for our Node.js shared library build. > > Reference: nodejs/node#7487 > > BUG= > [email protected], [email protected] > > Committed: https://crrev.com/9cf88c1c364cf76c1e745aa63196768435e8ef5d > Cr-Commit-Position: refs/heads/master@{#37814} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2155073002 Cr-Commit-Position: refs/heads/master@{#37822}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…rom-bytecode (patchset #3 id:80001 of https://codereview.chromium.org/2156753002/ ) Reason for revert: Breaks tsan: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/10758 Original issue's description: > [Intepreter] Always use BytecodeGraphBuilder when --turbo-from-bytecode > > Always use the BytecodeGraphBuilder when the --turbo-from-bytecode > is enabled, assuming the function should be compiled for Ignition. > Adds a new MaybeOptimizeIgnition function to runtime-profiler > which is called if the function should be optimized from bytecode > rather than going via full-codegen. > > BUG=v8:4280 > > Committed: https://crrev.com/9ca7db914be88e6792a88eab4a1988ee031d70c4 > Cr-Commit-Position: refs/heads/master@{#37921} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280 Review-Url: https://codereview.chromium.org/2165223002 Cr-Commit-Position: refs/heads/master@{#37925}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…ttps://codereview.chromium.org/2161953003/ ) Reason for revert: Clusterfuzz failures in parent CL https://codereview.chromium.org/2142933003/ Original issue's description: > Remove stack overflow boilerplate > > We no longer need to prepare the stack overflow error in advance now that > Errors are constructed in C++. > > [email protected] > BUG= > > Committed: https://crrev.com/ba95d10ccbe13e2fca427228483b045576f2dc4c > Cr-Commit-Position: refs/heads/master@{#37923} [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2169563003 Cr-Commit-Position: refs/heads/master@{#37927}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…https://codereview.chromium.org/2172653002/ ) Reason for revert: Blocks the roll: https://codereview.chromium.org/2189443003/ Doesn't work with the last chromium gyp bot. Original issue's description: > MIPS: Fix mksnapshot on big-endian. > > Paritally revert standalone.gypi changes in a451bd1 and introduce a new separate variable for the mkpeephole. > > On big-endian MIPS, qemu is used to build the snapshot, > because there's no simulator support for big-endian MIPS. > > BUG= > > Committed: https://crrev.com/928d2395c3fdf836cf9961cde96e6b274a6b1e20 > Cr-Commit-Position: refs/heads/master@{#38103} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2182633010 Cr-Commit-Position: refs/heads/master@{#38108}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…precise names. (patchset #3 id:40001 of https://codereview.chromium.org/2173773002/ ) Reason for revert: Breaks Roll https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/271267/steps/browser_tests%20%28with%20patch%29%20on%20Ubuntu-12.04/logs/MaterialHistoryBrowserTest.DrawerTest Original issue's description: > [heap] Give marking functions for incremental marking more precise names. > > BUG= > > Committed: https://crrev.com/4ac08c97f0c26cca3c0687b7349c929a4db2df43 > Cr-Commit-Position: refs/heads/master@{#38141} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2197583002 Cr-Commit-Position: refs/heads/master@{#38175}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…tchset #3 id:40001 of https://codereview.chromium.org/2206773003/ ) Reason for revert: [Sheriff] Leads to mac asan failures: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835 Original issue's description: > [api] Clean up scopes and precheck instantiations cache > > Make sure all the scopes used in api-natives.cc have inlineable constructors > and destructors. Additionally directly precheck the instantiations cache before > trying to enter the InvokeScope which sets the save_context. > > BUG=chromium:630217 > > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5 > Cr-Commit-Position: refs/heads/master@{#38346} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630217 Review-Url: https://codereview.chromium.org/2216903003 Cr-Commit-Position: refs/heads/master@{#38356}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
… id:40001 of https://codereview.chromium.org/2220463002/ ) Reason for revert: Need to revert https://codereview.chromium.org/2216563003 - just reland rebased version Original issue's description: > Hook up compiler dispatcher jobs to lazy parser. > > The lazy parser actually parses eagerly. It's called lazy because it > parses functions that were previously lazy parsed. D'uh. > > BUG=v8:5215 > [email protected] > > Committed: https://crrev.com/255cc15f98507e2bba49574f4dc38c74deb0ca2c > Cr-Commit-Position: refs/heads/master@{#38375} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5215 Review-Url: https://codereview.chromium.org/2211393003 Cr-Commit-Position: refs/heads/master@{#38378}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…tchset #1 id:1 of https://codereview.chromium.org/2216903003/ ) Reason for revert: asan failures are caused by a flaky stack-verflow (see https://codereview.chromium.org/2218033002 for a fix). Original issue's description: > Revert of [api] Clean up scopes and precheck instantiations cache (patchset #3 id:40001 of https://codereview.chromium.org/2206773003/ ) > > Reason for revert: > [Sheriff] Leads to mac asan failures: > https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/7835 > > Original issue's description: > > [api] Clean up scopes and precheck instantiations cache > > > > Make sure all the scopes used in api-natives.cc have inlineable constructors > > and destructors. Additionally directly precheck the instantiations cache before > > trying to enter the InvokeScope which sets the save_context. > > > > BUG=chromium:630217 > > > > Committed: https://crrev.com/a2496b942cad524f0f3144b107936eaa9a7c9fd5 > > Cr-Commit-Position: refs/heads/master@{#38346} > > [email protected],[email protected] > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:630217 > > Committed: https://crrev.com/e1b5cb43a9b90546ff5d6cea89ba17c485e842fb > Cr-Commit-Position: refs/heads/master@{#38356} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:630217 Review-Url: https://codereview.chromium.org/2217353002 Cr-Commit-Position: refs/heads/master@{#38401}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…#3 id:40001 of https://codereview.chromium.org/2236593002/ ) Reason for revert: The test is very flaky and made it on many configurations into the top 10 of the slowest tests: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/845 https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/15418 https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/12369/steps/Check/logs/durations Original issue's description: > Throw when case mapping result > max string length > > Throw 'Range Error: invalid string length' when the result of > case mapping is longer than the max string length (kMaxLength in > objects.h = 1 << 28 - 16). > > This is for case mapping with ICU. > > BUG=v8:5271 > TEST=intl/general/case-mapping.js with --icu_case_mapping > > Committed: https://crrev.com/c7a2046670468b900b9dbbb4ce45beb5e0e717fd > Cr-Commit-Position: refs/heads/master@{#38565} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5271 Review-Url: https://codereview.chromium.org/2236393002 Cr-Commit-Position: refs/heads/master@{#38582}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…ode and FinishCodeObject. (patchset #3 id:40001 of https://codereview.chromium.org/2229243003/ ) Reason for revert: There is a data race in the initialization of the Isolate::random_number_generator() Original issue's description: > [turbofan] Split CodeGenerator::GenerateCode into AssembleCode and FinishCodeObject. > > This CL splits CodeGenerator::GenerateCode into two new functions: > AssembleCode and FinishCodeObject. AssembleCode does not access or > modify the JS heap, which means that AssembleCode can be executed on > background threads. FinishCodeObject allocates the generated code object > on the JS heap and therefore has to be executed on the main thread. > > Implementation details: > The GenerateCode function has been split just before out-of-line code is > assembled. The reason is that code stubs may be generated when > out-of-line code is assembled, which potentially allocates these code > stubs on the heap. > > - Parts of initialization of the CodeGenerator has been moved from the > constructor to an Initialize function so that we can instantiate an empty > CodeGenerator object in PipelineData. > > [email protected], [email protected], [email protected] > > Committed: https://crrev.com/03058a2187e32cc4080612181802086527c116a2 > Cr-Commit-Position: refs/heads/master@{#38604} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2240523003 Cr-Commit-Position: refs/heads/master@{#38605}
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
…tors (patchset #3 id:40001 of https://codereview.chromium.org/2313723007/ ) Reason for revert: Mistaken revert to the wrong base Original issue's description: > Merged: Disallow tail calls from async functions and generators > > Revision: 5af4cd9 > > BUG=chromium:639270,v8:5301 > LOG=N > NOTRY=true > NOPRESUBMIT=true > NOTREECHECKS=true > [email protected], adamk > > Committed: https://chromium.googlesource.com/v8/v8/+/51c8996ee36aaee5f5fee04b0747ea27194937b7 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:639270,v8:5301 Review-Url: https://codereview.chromium.org/2317873002 Cr-Commit-Position: refs/branch-heads/5.4@{#27} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
…reter entry (patchset crosswalk-project#3 id:40001 of https://codereview.chromium.org/2705293011/ ) Reason for revert: Did not fix the issue. Original issue's description: > MIPS[64]: Fix unaligned arguments storage in Wasm-to-interpreter entry > > In Wasm-to-interpeter entry creation, arguments for the interpreter > are stored in an argument buffer. Depending on the order of the > arguments some arguments may be misaligned and this causes crashes > on those architectures that do not support unaligned memory access. > > TEST=cctest/test-wasm-interpreter-entry/TestArgumentPassing_AllTypes > BUG= > > Review-Url: https://codereview.chromium.org/2705293011 > Cr-Commit-Position: refs/heads/master@{#43476} > Committed: https://chromium.googlesource.com/v8/v8/+/84ff6e4c1997b63c01e95504c31ee6c5504430d5 [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Review-Url: https://codereview.chromium.org/2760603002 Cr-Commit-Position: refs/heads/master@{#43893}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
…hset crosswalk-project#3 id:40001 of https://codereview.chromium.org/2796033002/ ) Reason for revert: Breaks https://uberchromegw.corp.google.com/i/client.v8/builders/V8%20Linux%20-%20shared/builds/17291 Original issue's description: > [heap] Fix CompactionSpace test and move to unittests > > BUG=chromium:651354 > > Review-Url: https://codereview.chromium.org/2796033002 > Cr-Commit-Position: refs/heads/master@{#44382} > Committed: https://chromium.googlesource.com/v8/v8/+/ce9a2db1e13131245d8adc2757b9d9202ba568e0 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:651354 Review-Url: https://codereview.chromium.org/2793033004 Cr-Commit-Position: refs/heads/master@{#44383}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#3}
Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1}
Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#3}
Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1}
Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Float32x4Array and Int32x4Array element loading and storing by allocating SIMD registers and emitting SIMD movups instruction.
x64 port is nearly done and I am working on the ia32 port.