Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Commit

Permalink
Revert of MIPS: Fix mksnapshot on big-endian. (patchset #3 id:40001 of
Browse files Browse the repository at this point in the history
…https://codereview.chromium.org/2172653002/ )

Reason for revert:
Blocks the roll:
https://codereview.chromium.org/2189443003/

Doesn't work with the last chromium gyp bot.

Original issue's description:
> MIPS: Fix mksnapshot on big-endian.
>
> Paritally revert standalone.gypi changes in a451bd1 and introduce a new separate variable for the mkpeephole.
>
> On big-endian MIPS, qemu is used to build the snapshot,
> because there's no simulator support for big-endian MIPS.
>
> BUG=
>
> Committed: https://crrev.com/928d2395c3fdf836cf9961cde96e6b274a6b1e20
> Cr-Commit-Position: refs/heads/master@{#38103}

[email protected],[email protected],[email protected]
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2182633010
Cr-Commit-Position: refs/heads/master@{#38108}
  • Loading branch information
mi-ac authored and Commit bot committed Jul 27, 2016
1 parent f402d66 commit 366b00c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
13 changes: 1 addition & 12 deletions gypfiles/standalone.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -238,24 +238,13 @@
(v8_target_arch=="arm64" and host_arch!="arm64") or \
(v8_target_arch=="mipsel" and host_arch!="mipsel") or \
(v8_target_arch=="mips64el" and host_arch!="mips64el") or \
(v8_target_arch=="mips" and host_arch!="mips") or \
(v8_target_arch=="x64" and host_arch!="x64") or \
(OS=="android" or OS=="qnx")', {
'want_separate_host_toolset': 1,
}, {
'want_separate_host_toolset': 0,
}],
['(v8_target_arch=="arm" and host_arch!="arm") or \
(v8_target_arch=="arm64" and host_arch!="arm64") or \
(v8_target_arch=="mipsel" and host_arch!="mipsel") or \
(v8_target_arch=="mips64el" and host_arch!="mips64el") or \
(v8_target_arch=="mips" and host_arch!="mips") or \
(v8_target_arch=="mips64" and host_arch!="mips64") or \
(v8_target_arch=="x64" and host_arch!="x64") or \
(OS=="android" or OS=="qnx")', {
'want_separate_host_toolset_mkpeephole': 1,
}, {
'want_separate_host_toolset_mkpeephole': 0,
}],
['OS == "win"', {
'os_posix%': 0,
}, {
Expand Down
7 changes: 3 additions & 4 deletions src/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@
'action': ['<(mkpeephole_exec)', '<(INTERMEDIATE_DIR)/bytecode-peephole-table.cc' ],
'process_outputs_as_sources': 1,
'conditions': [
['want_separate_host_toolset_mkpeephole==1', {
['want_separate_host_toolset==1', {
'dependencies': ['mkpeephole#host'],
'toolsets': ['host'],
}, {
Expand Down Expand Up @@ -1794,8 +1794,7 @@
'base/utils/random-number-generator.h',
],
'conditions': [
['want_separate_host_toolset==1 or \
want_separate_host_toolset_mkpeephole==1', {
['want_separate_host_toolset==1', {
'toolsets': ['host', 'target'],
}, {
'toolsets': ['target'],
Expand Down Expand Up @@ -2381,7 +2380,7 @@
'interpreter/mkpeephole.cc'
],
'conditions': [
['want_separate_host_toolset_mkpeephole==1', {
['want_separate_host_toolset==1', {
'toolsets': ['host'],
}, {
'toolsets': ['target'],
Expand Down

0 comments on commit 366b00c

Please sign in to comment.