Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

Provide a ScreenOrientationDispatcherHost getter. #162

Merged
merged 1 commit into from
May 29, 2014
Merged

Provide a ScreenOrientationDispatcherHost getter. #162

merged 1 commit into from
May 29, 2014

Conversation

pozdnyakov
Copy link
Contributor

SSIA. We need it in order to be able to set ScreenOrientationProvider
from Xwalk.

@crosswalk-trybot
Copy link

Testing patch series with 849083b as its head.

Bot Status
Content Shell Android-x86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/71)
Content Shell Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/72)

@pozdnyakov pozdnyakov mentioned this pull request May 28, 2014
Closed
@kenchris
Copy link
Contributor

lgtm but fails

@crosswalk-trybot
Copy link

Testing patch series with ab786ad as its head.

Bot Status
Content Shell Android-x86 [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/72)
Content Shell Linux [FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/73)

Provide a ScreenOrientationDispatcherHost getter.
b89bd27 
SSIA. We need it in order to be able to set ScreenOrientationProvider
from Xwalk.
@crosswalk-trybot
Copy link

Testing patch series with b89bd27 as its head.

Bot Status
Content Shell Linux [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/74)
Content Shell Android-x86 [SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/73)

@pozdnyakov
Copy link
Contributor Author

@kenchris could you pls have another look (and merge if you like it :) )?

kenchris pushed a commit that referenced this pull request May 29, 2014
Merge pull request #162 from pozdnyakov/Add_ScreenOrientationDispatch…
c282374 
…erHost_getter

Provide a ScreenOrientationDispatcherHost getter.
@kenchris kenchris merged commit c282374 into crosswalk-project:master May 29, 2014
@kenchris
Copy link
Contributor

Sorry for the wait. I'm sick for the moment :(

darktears pushed a commit that referenced this pull request Sep 17, 2014
@thiemonagel
If booting for the first time skip auto-enrollment check.
2695c5b 
It will never return true on a vanilla device anyways and prevents some testing operations.

This is a copy of https://codereview.chromium.org/432093002/ -- Julian is OOO
and has asked me to get it reviewed and landed for him.  Since I can't edit his CL, I've created this copy.

The Chromium OS part of this change is at: https://chromium-review.googlesource.com/#/c/210470/

[email protected]
TBR=joaodasilva, stevenjb
BUG=397354
TEST=unit, manual
NOTRY=true

Review URL: https://codereview.chromium.org/462513004

Cr-Commit-Position: refs/heads/master@{#290607}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290607 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 8212232)

Review URL: https://codereview.chromium.org/516903002

Cr-Commit-Position: refs/branch-heads/2125@{#162}
Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears pushed a commit that referenced this pull request Nov 17, 2014
Revert "[android_webview] Hardcode the default text encoding to UTF-8."
3966126 
Broke the release builder:

../third_party/android_webview_glue/src/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:269:
error: cannot find symbol
        AwResource.setDefaultTextEncoding(

This reverts commit 846cb7c.

Original description:

>   [android_webview] Hardcode the default text encoding to UTF-8.
>
>   The WebView will use a fixed default value for the text encoding instead
>   of getting it from the platform. This is in attempt to unify behavior
>   between devices.
>
>   BUG=422366
>   [email protected]
>
>   Review URL: https://codereview.chromium.org/639113004
>
>   Cr-Commit-Position: refs/heads/master@{#299287}
>   (cherry picked from commit 72ea36f)
>
>   Conflicts:
>     DEPS
>     android_webview/buildbot/aosp_manifest.xml
>     android_webview/renderer/aw_content_renderer_client.h
>     chrome/renderer/chrome_content_renderer_client.h
>
>   Review URL: https://codereview.chromium.org/655703003
>
>   Cr-Commit-Position: refs/branch-heads/2171@{#140}
>   Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

BUG=424303
[email protected]

Review URL: https://codereview.chromium.org/654593003

Cr-Commit-Position: refs/branch-heads/2171@{#162}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
rakuco pushed a commit that referenced this pull request Feb 27, 2015
@jeisinger
Fix referrer policy handling in service workers
7b1cab7 
BUG=450589
[email protected],[email protected]

Review URL: https://codereview.chromium.org/862053002

Cr-Commit-Position: refs/heads/master@{#313072}
(cherry picked from commit 73fc00d)

Review URL: https://codereview.chromium.org/890973002

Cr-Commit-Position: refs/branch-heads/2272@{#162}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
@sheepmaster
Wait until a new profile has been created before deleting the active …
5ffd605 
…profile.

Previous review URL:
https://codereview.chromium.org/953453002

BUG=460859
[email protected]

Review URL: https://codereview.chromium.org/962143002

Cr-Commit-Position: refs/heads/master@{#318775}
(cherry picked from commit 447f643)

Review URL: https://codereview.chromium.org/984883002

Cr-Commit-Position: refs/branch-heads/2311@{#162}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 28, 2015
Ozone support for device special cases in keyboard event rewriting.
b4afab1 
Keyboard event rewriting has some special cases keyed on the device
name (Apple keyboards) or USB VID/PID (Hotrod remote), which had been
handled by special-case device inspection under X11, and not handled
at all under Ozone. This moves the properties to ui::DeviceDataManager
and makes the use in chromeos::EventRewriter platform-independent.

Changed ui::InputDevice::id and ash::DisplayInfo::touch_device_id_ from
'unsigned int' to 'int' in accordance with the coding style guide.

BUG=471753
[email protected],[email protected],[email protected]

Review URL: https://codereview.chromium.org/1073573002

Cr-Commit-Position: refs/heads/master@{#325660}
(cherry picked from commit 711f2fc)

Review URL: https://codereview.chromium.org/1071193002

Cr-Commit-Position: refs/heads/master@{#325042}
(cherry picked from commit a824971)

Review URL: https://codereview.chromium.org/1090863003

Cr-Commit-Position: refs/branch-heads/2357@{#162}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco pushed a commit that referenced this pull request Jun 8, 2015
Merge "<webview>: Remove Undocumented Resize DOM event"
ffe89df 
> <webview> had an undocumented resize event that we added as an experiment
> but it seems to be causing more harm than good, so let's just remove it.
>
> BUG=492648
> [email protected] for trivial browser_plugin_delegate.h change.
>
> Review URL: https://codereview.chromium.org/1155163009
>
> Cr-Commit-Position: refs/heads/master@{#331803}
> (cherry picked from commit 1f16a4a)

[email protected]

Review URL: https://codereview.chromium.org/1160393002

Cr-Commit-Position: refs/branch-heads/2403@{#162}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
Merge "cros: Remove up/down KEY_RELEASED accelerator"
8f757d2 
> These accelerators break the select popup for CfM OOBE and
> no longer needed for Gaia running inside webview.
>
> BUG=526953
>
> Review URL: https://codereview.chromium.org/1328513004
>
> Cr-Commit-Position: refs/heads/master@{#346727}
> (cherry picked from commit ae8040a)

Review URL: https://codereview.chromium.org/1314783009 .

Cr-Commit-Position: refs/branch-heads/2490@{#162}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
[ios] Removed CRLSets usage for WKWebView.
0a98514 
SecTrust API is used to make load/no-load decision for certs, while
CertVerifier is used to get rejection reason. Using CRLSets to get
rejection reason is impractical, because iOS blacklist is very
different from Chrome blacklist as well as cost to store CRLSets on
disk is very high.

BUG=None

Review URL: https://codereview.chromium.org/1465513002

Cr-Commit-Position: refs/heads/master@{#361212}
(cherry picked from commit c8fa67c)

Review URL: https://codereview.chromium.org/1488733002 .

Cr-Commit-Position: refs/branch-heads/2564@{#162}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
CountryNames: Separate data creation from usage
9cbfd02 
==Goal==
Fix a race condition in CountryNames-related code without complicating
it significantly.

==Non-goal==
Any deeper refactoring not necessary to fix the above race
condition. A discussion is needed to see whether once could avoid the
Singleton business and use some more common ways to store the country names
data (a database?), as well as whether it is necessary to compute it in
run-time. But that is explicitly out of scope of this CL.

==Content==
This CL makes CountryNames create its data (mappings from country names to
country codes and the appropriate collators for hashing the country names) on
construction, rather than on demand.

The main purpose of this change is to eliminate race conditions. Before this
CL, multiple threads could have trigger the data creation, and it is believed
to have caused data corruption and crashes.

Because the CountryNames creation is guaranteed by Singleton to only happen
once, it solves the threading issues.

However, there are caveats:
(Caveat A) CountryNames cannot get constructor arguments,
being created through Singleton's get(). But it needs to know which locale
Chrome is using. To circumvent this, it gets the information from a global
static string, and relies on the callsites of CountryNames to ensure
initialisation of this string.

To make that happen, every instance of AutofillManager ensures on its
construction, that said string is initialised. This is a bit clumsy (there is
an AutofillManager for each tab, but this pointer only needs to be initialised
once per Chrome's execution), but works -- CountryNames are never used earlier
than the first AutofillManager is constructed.

Also, while initialising the string is not guarded by any mutex, it is
safe -- AutofillManager gets constructed on the UI thread, so there are not
more concurrent constructions. And once the string is set, it is never set
again, so a constructed CountryNames can read it safely on any thread.

(Caveat B) Before this CL, the code was capable of generating more data for a
newly added locale on the fly. After this CL, it will only work for the locale
of the program during the CountryNames creation (and en_US as a fallback).
Note that Chrome does not seem to be able to change the language without
restart, so this should be no concern. The only unknown for me is CrOS -- I'm
not sure whether a new CountryNames instance is created for each user session.
But my suggestion is to wait with making the code more flexible until the
more systematic fix to the way it generates and stores the CountryNames data.

Finally, this CL adds a way to construct CountryNames with an explicit locale
in tests, and uses it in the appropriate unit tests.

BUG=571610

Review URL: https://codereview.chromium.org/1582353006

Cr-Commit-Position: refs/heads/master@{#371226}
(cherry picked from commit f39cbac)

Review URL: https://codereview.chromium.org/1646453002 .

Cr-Commit-Position: refs/branch-heads/2623@{#162}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
@galmacky
Migrate *-ime-thread switches to feature API
9d4eb20 
The new Feature API is the simplest way to run Finch experiments with.
Also, it gets propagated to the renderer.

BUG=551193, 591149

Review URL: https://codereview.chromium.org/1771223002

Cr-Commit-Position: refs/heads/master@{#380256}
(cherry picked from commit 7ded375)

Review URL: https://codereview.chromium.org/1784743002 .

Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#162}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
Disable HTTP/2 Alternative Service for different host.
53e8439 
Disable HTTP/2 Alternative Service if origin and alternative have different
hostnames.  This is a temporary workaround until https://crbug.com/615413 is
fixed.

BUG=615637

Review-Url: https://codereview.chromium.org/2017323002
Cr-Commit-Position: refs/heads/master@{#396665}
(cherry picked from commit 8bef8da)

Review URL: https://codereview.chromium.org/2026293002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#162}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@johnmellor
Revert "[Home] Account for incognito in modern tab title"
b0bb3a8 
This reverts commit 6dd103c.

Reason for revert: this broke
https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/2411
with error message:
../../chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:128: error: cannot find symbol
        if (!DeviceFormFactor.isTablet() && !FeatureUtilities.isChromeHomeModernEnabled())

Original change's description:
> [Home] Account for incognito in modern tab title
> 
> Titles in Chrome Modern are not always white, incognito still uses a
> dark theme.
> 
> BUG=760740
> [email protected]
> 
> (cherry picked from commit fba6588)
> 
> Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9
> Reviewed-on: https://chromium-review.googlesource.com/651570
> Reviewed-by: Theresa <[email protected]>
> Commit-Queue: Matthew Jones <[email protected]>
> Cr-Original-Commit-Position: refs/heads/master@{#499781}
> Reviewed-on: https://chromium-review.googlesource.com/661319
> Reviewed-by: Matthew Jones <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#147}
> Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

[email protected],[email protected]

Change-Id: I12ab4b52aa3c9f6007f26388cfe14e40b3e90f90
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 764200,760740
Reviewed-on: https://chromium-review.googlesource.com/663381
Reviewed-by: John Mellor <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#162}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
@iotitan
Revert "Revert "[Home] Account for incognito in modern tab title""
31e34ea 
This reverts commit b0bb3a8.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> Revert "[Home] Account for incognito in modern tab title"
> 
> This reverts commit 6dd103c.
> 
> Reason for revert: this broke
> https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/2411
> with error message:
> ../../chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:128: error: cannot find symbol
>         if (!DeviceFormFactor.isTablet() && !FeatureUtilities.isChromeHomeModernEnabled())
> 
> Original change's description:
> > [Home] Account for incognito in modern tab title
> > 
> > Titles in Chrome Modern are not always white, incognito still uses a
> > dark theme.
> > 
> > BUG=760740
> > [email protected]
> > 
> > (cherry picked from commit fba6588)
> > 
> > Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9
> > Reviewed-on: https://chromium-review.googlesource.com/651570
> > Reviewed-by: Theresa <[email protected]>
> > Commit-Queue: Matthew Jones <[email protected]>
> > Cr-Original-Commit-Position: refs/heads/master@{#499781}
> > Reviewed-on: https://chromium-review.googlesource.com/661319
> > Reviewed-by: Matthew Jones <[email protected]>
> > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#147}
> > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
> 
> [email protected],[email protected]
> 
> Change-Id: I12ab4b52aa3c9f6007f26388cfe14e40b3e90f90
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 764200,760740
> Reviewed-on: https://chromium-review.googlesource.com/663381
> Reviewed-by: John Mellor <[email protected]>
> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#162}
> Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

[email protected],[email protected],[email protected]

Change-Id: I8afb1fdf63fefacf33bba8bde5a9065eac85a295
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 764200, 760740
Reviewed-on: https://chromium-review.googlesource.com/663738
Reviewed-by: Matthew Jones <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#166}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pozdnyakov @crosswalk-trybot @kenchris