[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. #166

zhang-qing · 2014-06-11T06:22:00Z

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos.

BUG=XWALK-1781 (https://crosswalk-project.org/jira/browse/XWALK-1781)

crosswalk-trybot · 2014-06-11T06:22:02Z

Testing patch series with e9f3668 as its head.

Bot	Status
Content Shell Android-x86	[FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/80)
Content Shell Linux	[FAILED 💔](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/81)

crosswalk-trybot · 2014-06-11T06:32:14Z

Testing patch series with 795f568 as its head.

Bot	Status
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/81)
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/82)

zhang-qing · 2014-06-11T07:01:22Z

@halton , please help me to review when you are free. Thanks alot.

halton · 2014-06-11T07:09:54Z

Some nit suggestions on git log, I would like

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos.

BUG=XWALK-1781

halton · 2014-06-11T07:12:37Z

content/common/gpu/media/vaapi_video_decode_accelerator_wayland.cc

+
+  unsigned int al = 4 * size_.width();  // Alignment length.
+  if (al != va_image_.pitches[0]) {  // Check RGBA data alignment.
+    unsigned char* bhandle = (unsigned char*)buffer;


please use static_cast in C++

zhang-qing · 2014-06-11T07:41:12Z

Does the situation that a clip not RGBA happend a lot?
--> All H264 HW acc would output RGBA image after decoded.
What other video player normal do for this kind of clip? realign as this PR? or report a corrupted? Or continue play with the bad image.
--> Keep playing but with bad image. Even this incorrect video not alway exists in web.
Does this way is correct to identify the video clip that not RGBA aligned?
--> This situation type never occurs.

crosswalk-trybot · 2014-06-11T07:45:14Z

Testing patch series with cfe6b18 as its head.

Bot	Status
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/82)
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/83)

halton · 2014-06-11T08:00:13Z

So my concern is why we need handle that corrupted clip, while other player does not.

zhang-qing · 2014-06-11T08:04:21Z

They did in pixmap or some part of space, once not alignment frame while decoding.

crosswalk-trybot · 2014-06-12T01:32:51Z

Testing patch series with 0955d0a as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/84)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/83)

halton · 2014-06-12T09:55:55Z

content/common/gpu/media/vaapi_video_decode_accelerator_wayland.cc

+
+  unsigned int al = 4 * size_.width();  // Alignment length.
+  if (al != va_image_.pitches[0]) {  // Re-Check RGBA data alignment.
+    unsigned char *bhandle = static_cast<unsigned char *>(buffer);


nit comment, unsigned char* -> unsigned char* to follow the chromium coding style.

And the comment is suggested as whole before this code block, why and how to fix.

html5 mp4 videos. Such not aligned phenomenon occurs only in special size video in None-X11. So fix it by re-check and re-aligne HW decoded frame RGBA data. BUG=XWALK-1781 (https://crosswalk-project.org/jira/browse/XWALK-1781)

crosswalk-trybot · 2014-06-13T01:23:42Z

Testing patch series with 29e684f as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/85)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/84)

halton · 2014-06-13T01:28:56Z

content/common/gpu/media/vaapi_video_decode_accelerator_wayland.cc

+    for (int i = 0; i < size_.height(); i++) {  // Realign filled video frame.
+      memcpy(bhandle + (i * al), bhandle + (i * (va_image_.pitches[0])), al);
+    }
+  }


Sorry that I'm not so clear last time. I meant the comment at end is kind of strange, I'd suggest comment them as whole para before the code block.

crosswalk-trybot · 2014-06-13T02:21:40Z

Testing patch series with 3c60cf0 as its head.

Bot	Status
Content Shell Linux	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Linux/builds/86)
Content Shell Android-x86	[SUCCESS 💚](https://build.crosswalk-project.org/try/builders/Content Shell Android-x86/builds/85)

halton · 2014-06-13T02:24:10Z

lgtm.

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos.

… videos This patch is cherry picked from Qing's PR crosswalk-project/chromium-crosswalk#166 Bug = XWALK-2265

BUG= Review URL: https://codereview.chromium.org/503743002 Cr-Commit-Position: refs/heads/master@{#291877} (cherry picked from commit fe6080f) Review URL: https://codereview.chromium.org/521813004 Cr-Commit-Position: refs/branch-heads/2125@{#166} Cr-Branched-From: b68026d-refs/heads/master@{#290040}

s/getActionBar/getSupportActionBar in Desktop.java which uses ActionBarActivity from the support library. BUG=423875 Review URL: https://codereview.chromium.org/655243004 Cr-Commit-Position: refs/heads/master@{#299827} (cherry picked from commit 5b154b8) Review URL: https://codereview.chromium.org/655383004 Cr-Commit-Position: refs/branch-heads/2171@{#166} Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

…nsManager. As in the UsbEventRouter the UsbService must be observed from the FILE thread (until bug 427985 is resolved, which will be soon). This change fixes a DCHECK(CalledOnValidThread()) in UsbService::AddObserver when permission to access an ephemeral (no serial number) device is added and the DevicePermissionsManager starts listening for disconnection of that device. BUG=452652 NOTRY=true Review URL: https://codereview.chromium.org/882813002 (cherry-picked from commit 897bbc2) Cr-Commit-Position: refs/heads/master@{#313548} Review URL: https://codereview.chromium.org/872313004 Cr-Commit-Position: refs/branch-heads/2272@{#166} Cr-Branched-From: 827a380-refs/heads/master@{#310958}

…registration page This requires a few changes to how we evaluate pages during the saving process. 1) Instead of ignoring forms where there are more than 3 password fields, assume that those fields are not related to actual passwords. Also change the case of 3 passwords to assume that if the first and second password match, that the third is not related. I don't have statistics on this, but I have seen security questions that are entered into password fields much more often than I have seen a new password entered before and old password (which was the previous assumption). 2) Move change password detection to work on the submitted password form instead of the observed form. The submitted form is more likely to be identified correctly because we have additional data after submission. This failed on Macy's because we incorrectly assume that, given the number of password fields, one of them is a current password field during parsing. 3) Don't require HTML field attributes to match for signup forms. This is normally required because otherwise we can't fill the password we have just saved. However in the case of signup forms this doesn't matter because we don't want to fill on the same form again anyway. BUG=452306, 451631 Review URL: https://codereview.chromium.org/944163003 Cr-Commit-Position: refs/heads/master@{#318850} (cherry picked from commit 33138a0) Review URL: https://codereview.chromium.org/978363004 Cr-Commit-Position: refs/branch-heads/2311@{#166} Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}

BUG=473283 [email protected] NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1051273006 Cr-Commit-Position: refs/heads/master@{#323915} (cherry picked from commit 82ad942) Review URL: https://codereview.chromium.org/1075963003 Cr-Commit-Position: refs/branch-heads/2357@{#166} Cr-Branched-From: 59d4494-refs/heads/master@{#323860}

…he top. We have to ensure that the task manager by default (without any sorting) shows the browser process task at the top of the list. This CL also makes the RendererTasks match the old task manager behavior by showing zeros for their network usage instead of N/As even when no network bytes have been reported for them. [email protected] BUG=523992 Review URL: https://codereview.chromium.org/1322043003 Cr-Commit-Position: refs/heads/master@{#346950} (cherry picked from commit 5a3948d) Review URL: https://codereview.chromium.org/1310363005 . Cr-Commit-Position: refs/branch-heads/2490@{#166} Cr-Branched-From: 7790a35-refs/heads/master@{#344925}

…ed for deletion This patch fixes the problems caused by: * HasOfflinePages * GetPageByBookmarkId * GetPageByOfflineURL * GetPageByOnlineURL All of which allow for access to the offline page that is marked for deletion, which means there is no valid bookmark corresponding to them. This leads to crashes in the bookmark UI, as well as exposing functionality that should not work. BUG=560424 Review URL: https://codereview.chromium.org/1475883003 Cr-Commit-Position: refs/heads/master@{#361746} (cherry picked from commit 1a6c2e1) Review URL: https://codereview.chromium.org/1487913002 . Cr-Commit-Position: refs/branch-heads/2564@{#166} Cr-Branched-From: 1283eca-refs/heads/master@{#359700}

…terator. BUG=581517 [email protected] Review URL: https://codereview.chromium.org/1642663003 . Cr-Commit-Position: refs/heads/master@{#371837} (cherry picked from commit 0c97b34) Review URL: https://codereview.chromium.org/1644693002 . Cr-Commit-Position: refs/branch-heads/2623@{#166} Cr-Branched-From: 92d7753-refs/heads/master@{#369907}

…set #1 id:1 of https://codereview.chromium.org/1782563002/ ) Reason for revert: Merged incorrectly. Will revert for now and remerge. Original issue's description: > Takeover MT initiated animations from the compositor > > This is a followup CL to https://crrev.com/1734063003/. It finishes a > MT initiated animation running on the compositor, on the MT. > > BUG=581875 > > Review URL: https://codereview.chromium.org/1770443002 > > Cr-Commit-Position: refs/heads/master@{#379868} > (cherry picked from commit d0eaee2) TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=581875 Review URL: https://codereview.chromium.org/1778223002 Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#166} Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}

The code checks that a ContextProvider was able to be found by checking the |gl| field. But if the ContextProvider was created but lost, and GrContext was not created yet, then it will fail to initialize and be null. We should avoid trying to use this context then (and not crash). [email protected] BUG=612087 Review-Url: https://codereview.chromium.org/2003833002 Cr-Commit-Position: refs/heads/master@{#395222} (cherry picked from commit 53f7ec9) Review URL: https://codereview.chromium.org/2025353002 . Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#166} Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}

This reverts commit b0bb3a8. Reason for revert: <INSERT REASONING HERE> Original change's description: > Revert "[Home] Account for incognito in modern tab title" > > This reverts commit 6dd103c. > > Reason for revert: this broke > https://uberchromegw.corp.google.com/i/official.android/builders/official-arm/builds/2411 > with error message: > ../../chrome/android/java/src/org/chromium/chrome/browser/compositor/LayerTitleCache.java:128: error: cannot find symbol > if (!DeviceFormFactor.isTablet() && !FeatureUtilities.isChromeHomeModernEnabled()) > > Original change's description: > > [Home] Account for incognito in modern tab title > > > > Titles in Chrome Modern are not always white, incognito still uses a > > dark theme. > > > > BUG=760740 > > [email protected] > > > > (cherry picked from commit fba6588) > > > > Change-Id: I82800234101f3755dcb3214c65942ae82e59b3d9 > > Reviewed-on: https://chromium-review.googlesource.com/651570 > > Reviewed-by: Theresa <[email protected]> > > Commit-Queue: Matthew Jones <[email protected]> > > Cr-Original-Commit-Position: refs/heads/master@{#499781} > > Reviewed-on: https://chromium-review.googlesource.com/661319 > > Reviewed-by: Matthew Jones <[email protected]> > > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#147} > > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098} > > [email protected],[email protected] > > Change-Id: I12ab4b52aa3c9f6007f26388cfe14e40b3e90f90 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 764200,760740 > Reviewed-on: https://chromium-review.googlesource.com/663381 > Reviewed-by: John Mellor <[email protected]> > Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#162} > Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098} [email protected],[email protected],[email protected] Change-Id: I8afb1fdf63fefacf33bba8bde5a9065eac85a295 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 764200, 760740 Reviewed-on: https://chromium-review.googlesource.com/663738 Reviewed-by: Matthew Jones <[email protected]> Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#166} Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}

halton reviewed Jun 11, 2014
View reviewed changes

zhang-qing changed the title ~~[Tizen] Fix: The screen displayed abnormally when playing some size of html5 mp4 videos on Tizen IVI.~~ [Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. Jun 11, 2014

halton reviewed Jun 12, 2014
View reviewed changes

halton reviewed Jun 13, 2014
View reviewed changes

rakuco pushed a commit that referenced this pull request Jun 13, 2014

Merge pull request #166 from zhang-qing/m5

1347ca7

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos.

rakuco merged commit 1347ca7 into crosswalk-project:master Jun 13, 2014

qjia7 added a commit to qjia7/ozone-wayland that referenced this pull request Aug 19, 2014

Fixed screen displayed abnormally when playing some size of html5 mp4…

77ea8e8

… videos This patch is cherry picked from Qing's PR crosswalk-project/chromium-crosswalk#166 Bug = XWALK-2265

qjia7 mentioned this pull request Aug 19, 2014

Fixed screen displayed abnormally when playing some size of html5 mp4 vi... intel/ozone-wayland#268

Closed

qjia7 added a commit to qjia7/ozone-wayland that referenced this pull request Aug 20, 2014

Fixed screen displayed abnormally when playing some size of html5 mp4…

b8f58a1

… videos This patch is cherry picked from Qing's PR crosswalk-project/chromium-crosswalk#166 Bug = XWALK-2265

qjia7 added a commit to qjia7/ozone-wayland that referenced this pull request Aug 21, 2014

Fixed screen displayed abnormally when playing some size of html5 mp4…

9c77391

… videos This patch is cherry picked from Qing's PR crosswalk-project/chromium-crosswalk#166 Bug = XWALK-2265

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. #166

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. #166

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

zhang-qing commented Jun 11, 2014

halton commented Jun 11, 2014

halton Jun 11, 2014

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

halton commented Jun 11, 2014

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 12, 2014

halton Jun 12, 2014

crosswalk-trybot commented Jun 13, 2014

halton Jun 13, 2014

crosswalk-trybot commented Jun 13, 2014

halton commented Jun 13, 2014

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. #166

[Tizen] Fixed screen displayed abnormally when playing some size of html5 mp4 videos. #166

Conversation

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

zhang-qing commented Jun 11, 2014

halton commented Jun 11, 2014

halton Jun 11, 2014

Choose a reason for hiding this comment

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 11, 2014

halton commented Jun 11, 2014

zhang-qing commented Jun 11, 2014

crosswalk-trybot commented Jun 12, 2014

halton Jun 12, 2014

Choose a reason for hiding this comment

crosswalk-trybot commented Jun 13, 2014

halton Jun 13, 2014

Choose a reason for hiding this comment

crosswalk-trybot commented Jun 13, 2014

halton commented Jun 13, 2014