Skip to content
This repository has been archived by the owner on Apr 3, 2020. It is now read-only.

[Android] Change the API for ApplicationStatus in base dir. #140

Merged
merged 1 commit into from
Apr 2, 2014
Merged

[Android] Change the API for ApplicationStatus in base dir. #140

merged 1 commit into from
Apr 2, 2014

Conversation

yongsheng
Copy link
Contributor

Chromium class inherits from Application directly. This is not suitable
for Crosswalk embedding API. Instead, define a new API which can pass Application
instance as the parameter instead of asking users' application inheriting from
Chromium Application.

@yongsheng yongsheng mentioned this pull request Apr 1, 2014
Merged
@yongsheng
Copy link
Contributor Author

@darktears @rakuco please review it. thanks.

@yongsheng yongsheng restored the next branch April 1, 2014 09:48
@darktears
Copy link
Contributor

The change is ok for me. One nitpick, if you could put the link to CL breaking the code in the commit log, it will be easier for us in the future to track.

Question : do you think we could upstream that, arguing that embedders like Crosswalk don't want to inherit from BaseChromiumApplication and instead providing some abstraction like you did is a better design?

@darktears
Copy link
Contributor

Obviously we would land it as-is in crosswalk-6 but hopefully we could get rid of it in crosswalk-7.

@darktears
Copy link
Contributor

https://codereview.chromium.org/159173002 I guess

@yongsheng
Copy link
Contributor Author

@darktears, yes, agree with you. actually I want to discuss it in upstream. will do that. thanks.
will add the CL in the commit log.

[Android] Change the API for ApplicationStatus in base dir.
5833e50 
Chromium class inherits from Application directly. This is not suitable
for Crosswalk embedding API. Instead, define a new API which can pass Application
instance as the parameter instead of asking users' application inheriting from
Chromium Application.
This fix is due to the change in upstream:
https://codereview.chromium.org/159173002
@darktears
Copy link
Contributor

@yongsheng : LGTM. Please add me in CC in the CL so If I can help. It will also let me know when it lands so I can track whether I can get rid of the patch in chromium-crosswalk.

darktears added a commit that referenced this pull request Apr 2, 2014
@darktears
Merge pull request #140 from yongsheng/next
0dfe775 
[Android] Change the API for ApplicationStatus in base dir.
@darktears darktears merged commit 0dfe775 into crosswalk-project:next Apr 2, 2014
darktears pushed a commit that referenced this pull request Sep 17, 2014
@hush-at-google
Add an "isInsideVSync" check.
957ca78 
Prevent calling postInvalidateOnAnimate inside VSync handler, because
this will cause the invalidation to be one frame delayed.

BUG=394604

Review URL: https://codereview.chromium.org/470523006

Cr-Commit-Position: refs/heads/master@{#291525}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291525 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 10288a7)

[Android] Allow redundant |StartObservingRootWindow()| calls

Redundant requests to observe the window are harmless, and should be supported
given the undefined relationship and timing between
|RWHVAndroid::SetContentViewCore()| and |RWHVAndroid::WasShown()|, both of which
can trigger observing of the root window.

BUG=406651,394604
NOTRY=true
[email protected]

Review URL: https://codereview.chromium.org/493053004

Cr-Commit-Position: refs/heads/master@{#291596}
(cherry picked from commit 789317e)

[Android] Consolidate vsync request logic in RWHVAndroid

The current vsync subscription scheme in RWHVAndroid is rather ad-hoc. Formalize
the request logic by creating explicit request types, avoiding redundant vsync
requests (and the associated JNI call) while also enforcing the validity of
such requests (for WebView).

BUG=394604

Review URL: https://codereview.chromium.org/492923002

Cr-Commit-Position: refs/heads/master@{#291296}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291296 0039d316-1c4b-4281-b951-d872f2087c98
(cherry picked from commit 03cc321)

Review URL: https://codereview.chromium.org/518453002

Cr-Commit-Position: refs/branch-heads/2125@{#140}
Cr-Branched-From: b68026d-refs/heads/master@{#290040}
darktears pushed a commit that referenced this pull request Nov 17, 2014
[android_webview] Hardcode the default text encoding to UTF-8.
846cb7c 
The WebView will use a fixed default value for the text encoding instead
of getting it from the platform. This is in attempt to unify behavior
between devices.

BUG=422366
[email protected]

Review URL: https://codereview.chromium.org/639113004

Cr-Commit-Position: refs/heads/master@{#299287}
(cherry picked from commit 72ea36f)

Conflicts:
	DEPS
	android_webview/buildbot/aosp_manifest.xml
	android_webview/renderer/aw_content_renderer_client.h
	chrome/renderer/chrome_content_renderer_client.h

Review URL: https://codereview.chromium.org/655703003

Cr-Commit-Position: refs/branch-heads/2171@{#140}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
darktears pushed a commit that referenced this pull request Nov 17, 2014
Revert "[android_webview] Hardcode the default text encoding to UTF-8."
3966126 
Broke the release builder:

../third_party/android_webview_glue/src/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java:269:
error: cannot find symbol
        AwResource.setDefaultTextEncoding(

This reverts commit 846cb7c.

Original description:

>   [android_webview] Hardcode the default text encoding to UTF-8.
>
>   The WebView will use a fixed default value for the text encoding instead
>   of getting it from the platform. This is in attempt to unify behavior
>   between devices.
>
>   BUG=422366
>   [email protected]
>
>   Review URL: https://codereview.chromium.org/639113004
>
>   Cr-Commit-Position: refs/heads/master@{#299287}
>   (cherry picked from commit 72ea36f)
>
>   Conflicts:
>     DEPS
>     android_webview/buildbot/aosp_manifest.xml
>     android_webview/renderer/aw_content_renderer_client.h
>     chrome/renderer/chrome_content_renderer_client.h
>
>   Review URL: https://codereview.chromium.org/655703003
>
>   Cr-Commit-Position: refs/branch-heads/2171@{#140}
>   Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}

BUG=424303
[email protected]

Review URL: https://codereview.chromium.org/654593003

Cr-Commit-Position: refs/branch-heads/2171@{#162}
Cr-Branched-From: 267aeeb-refs/heads/master@{#297060}
mrunalk pushed a commit that referenced this pull request Feb 10, 2015
[android_webview] Add the apk resources to the Android build.
6d0cd79 
This adds the resources from the apk/ folder to the Android build
to enable removing the downstream resources.

BUG=None
TESTS=android_aosp bot
[email protected]
[email protected]

Review URL: https://codereview.chromium.org/828153004

Cr-Commit-Position: refs/heads/master@{#311268}
(cherry picked from commit 56a8804)

Review URL: https://codereview.chromium.org/882843004

Cr-Commit-Position: refs/branch-heads/2272@{#140}
Cr-Branched-From: 827a380-refs/heads/master@{#310958}
rakuco pushed a commit that referenced this pull request Mar 12, 2015
Incrementing VERSION to 42.0.2311.21
a087aaf 
Cr-Commit-Position: refs/branch-heads/2311@{#140}
Cr-Branched-From: 09b7de5-refs/heads/master@{#317474}
rakuco pushed a commit that referenced this pull request Apr 28, 2015
@jamiewalch
Position the <img> cursor relative to the client plugin, not the window.
f8e3147 
BUG=475994

Review URL: https://codereview.chromium.org/1091603003

Cr-Commit-Position: refs/heads/master@{#325391}
(cherry picked from commit 62cd7c8)

[email protected]

Review URL: https://codereview.chromium.org/1092073003

Cr-Commit-Position: refs/branch-heads/2357@{#140}
Cr-Branched-From: 59d4494-refs/heads/master@{#323860}
rakuco pushed a commit that referenced this pull request Jun 8, 2015
Updating XTBs based on .GRDs from branch 2403
f0075c5 
Cr-Commit-Position: refs/branch-heads/2403@{#140}
Cr-Branched-From: f54b809-refs/heads/master@{#330231}
mrunalk pushed a commit that referenced this pull request Sep 22, 2015
@hshi-chromium
H264 Decoder: move cut off logic from Construct to ModifyRefPicList().
f7db687 
The ConstructRefPicListsP/B() functions are supposed to be slice agnostic.

The cut off logic is based on per-slice num_ref_idx_lX_active_minus1 values
in the slice header, and therefore it should belong to the ModifyRefPicList()
function.

BUG=479953
TEST=verify no corruption on xfnity, trybot, vda unit test

Review URL: https://codereview.chromium.org/1318283007

Cr-Commit-Position: refs/heads/master@{#346947}
(cherry picked from commit 5e19b06)

[email protected]
NOTRY=true
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/1323143006

Cr-Commit-Position: refs/branch-heads/2490@{#140}
Cr-Branched-From: 7790a35-refs/heads/master@{#344925}
mrunalk pushed a commit that referenced this pull request Dec 18, 2015
[Merge][Autofill] No longer pass FormStructure pointers in ParseQuery…
ac6f227 
…Response.

Use form signatures to look up forms in |form_structures_|, which is
guaranteed to be valid.

BUG=557713,557740,557800
TEST=Existing

Review URL: https://codereview.chromium.org/1457793002

Cr-Commit-Position: refs/heads/master@{#360580}
(cherry picked from commit 29fda7f)

[email protected]

Review URL: https://codereview.chromium.org/1475053003 .

Cr-Commit-Position: refs/branch-heads/2564@{#140}
Cr-Branched-From: 1283eca-refs/heads/master@{#359700}
rakuco pushed a commit that referenced this pull request Mar 3, 2016
Protect all access to the native RemoteMediaPlayerBridge
57ba5fc 
BUG=580221

Review URL: https://codereview.chromium.org/1633463002

Cr-Commit-Position: refs/heads/master@{#371235}
(cherry picked from commit 39f0ae5)

Review URL: https://codereview.chromium.org/1639543004 .

Cr-Commit-Position: refs/branch-heads/2623@{#140}
Cr-Branched-From: 92d7753-refs/heads/master@{#369907}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request May 17, 2016
Incrementing VERSION to 50.0.2661.22
e8bb3c4 
Cr-Commit-Position: refs/branch-heads/2661@{crosswalk-project#140}
Cr-Branched-From: ef6f6ae-refs/heads/master@{#378081}
huningxin pushed a commit to huningxin/chromium-croswalk that referenced this pull request Oct 9, 2016
Record the return value of NativeLibraryPreloader.loadLibrary in UMA
b5288a8 
BUG=614166

Review-Url: https://codereview.chromium.org/2015533005
Cr-Commit-Position: refs/heads/master@{#396632}
(cherry picked from commit 8369bdb)

Review URL: https://codereview.chromium.org/2027793002 .

Cr-Commit-Position: refs/branch-heads/2743@{crosswalk-project#140}
Cr-Branched-From: 2b3ae3b-refs/heads/master@{#394939}
imreotto pushed a commit to tenta-browser/chromium-crosswalk that referenced this pull request Nov 2, 2017
History page keeps remote and local results in lock step.
dbbc998 
When signed in and returning Web History results, the previous
implementation of the BrowsingHistoryService would be to fetch about
history::QueryOptions::max_count (100) worth of results from both
local and web history. Then these results would be merged together in
reverse chronological order, and thrown back to the UI. The UI would
preset the user with a scrollbar, and when they scrolled to somewhere
near the end of the results, the UI would take the results on screen,
grab the last one, take the timestamp of that entry, and ask the
BrowsingHistoryService for another page, started at that timestamp.

This works nicely if web and local history return identical results,
but if they return different results, we end up skipping ahead and
missing results. This is extremely bad if one source is missing a
large gap, the other source only gets a page of results before it gets
cut off.

To fix this, stop returning results when one source is ahead of the
other. These pending results are stored in a closure that can be used
when the next page is needed. Things got a bit ugly tracking all the
different pieces of state and some refactoring was done to try to keep
things as nice as possible.

Bug: 728727
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3709c21095fce7840ba88f3c094ccb5c94dee23d
Reviewed-on: https://chromium-review.googlesource.com/577968
Reviewed-by: Ramya Sharma <[email protected]>
Reviewed-by: calamity <[email protected]>
Reviewed-by: Yusuf Ozuysal <[email protected]>
Reviewed-by: Sylvain Defresne <[email protected]>
Reviewed-by: Theresa <[email protected]>
Commit-Queue: Sky Malice <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#499655}(cherry picked from commit d441317)
Reviewed-on: https://chromium-review.googlesource.com/661197
Reviewed-by: Sky Malice <[email protected]>
Cr-Commit-Position: refs/branch-heads/3202@{crosswalk-project#140}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yongsheng @darktears