Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestAFter corrected to RequestAAfter #743

Open
SOF3 opened this issue Jun 9, 2023 · 3 comments
Open

RequestAFter corrected to RequestAAfter #743

SOF3 opened this issue Jun 9, 2023 · 3 comments
Labels
A-token Area: tokenization, including definition of identifiers and words C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing

Comments

@SOF3
Copy link
Contributor

SOF3 commented Jun 9, 2023

$ typos test.txt --diff
--- test.txt    original
+++ test.txt    fixed
@@ -1 +1 @@
-RequestAFter
+RequestAAfter

It should be corrected to RequestAfter instead.

@epage epage added the C-enhancement Category: Raise on the bar on expectations label Jun 9, 2023
@epage
Copy link
Collaborator

epage commented Jun 9, 2023

Any thoughts on how we can identify invalid wordsplits like this?

@SOF3
Copy link
Contributor Author

SOF3 commented Jun 10, 2023

Citation needed, but my understanding is that single-letter words (especially articles like "a") are very uncommon in camel/pascal case identifiers. If a word is detected to be missing its first character and the previous character is uppercase, could we consider merging them?

@epage
Copy link
Collaborator

epage commented Jun 12, 2023

Citation needed, but my understanding is that single-letter words (especially articles like "a") are very uncommon in camel/pascal case identifiers.

I agree and with the fact that this can bite us in other ways, and the complexity involved in trying to support it, I would lean towards us not supporting this.

@epage epage added S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing A-token Area: tokenization, including definition of identifiers and words labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-token Area: tokenization, including definition of identifiers and words C-enhancement Category: Raise on the bar on expectations S-waiting-on-design Status: Waiting on user-facing design to be resolved before implementing
Projects
None yet
Development

No branches or pull requests

2 participants