Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Implementor" should not be a typo #1226

Closed
SOF3 opened this issue Feb 13, 2025 · 0 comments · Fixed by #1229
Closed

"Implementor" should not be a typo #1226

SOF3 opened this issue Feb 13, 2025 · 0 comments · Fixed by #1229

Comments

@SOF3
Copy link
Contributor

SOF3 commented Feb 13, 2025

Introduced in the January 2025 edition #1200 (comment), "implementor" is autocorrected to "implementer". However:

  • This is the term used in documentation generated by rustdoc
  • "Implementor" is not significantly less common than "implementer", depending on the time
Image

(ngram link retrieved from https://english.stackexchange.com/a/358111/198517)

github-merge-queue bot pushed a commit to bevyengine/bevy that referenced this issue Feb 13, 2025
# Objective

Update typos, fix new typos.

1.29.6 was just released to fix an
[issue](crate-ci/typos#1228) where January's
corrections were not included in the binaries for the last release.

Reminder: typos can be tossed in the monthly [non-critical corrections
issue](crate-ci/typos#1221).

## Solution

I chose to allow `implementors`, because a good argument seems to be
being made [here](crate-ci/typos#1226) and
there is now a PR to address that.

## Discussion

Should I exclude `bevy_mikktspace`?

At one point I think we had an informal policy of "don't mess with
mikktspace until #9050 is merged"
but it doesn't seem like that is likely to be merged any time soon.

I think these particular corrections in mikktspace are fine because
- The same typo mistake seems to have been fixed in that PR
- The entire file containing these corrections was deleted in that PR

## Typo of the Month

correspindong -> corresponding
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant