Fix orderbook openapi scheme

[shoom3301]

Fixes cowprotocol/cowswap#2045

To avoid code duplication and have one source of truth we decided to generate typescript code based on Swagger scheme:
cowprotocol/cow-sdk#97

This PR levels out contradictions between the openapi scheme and the implementation.

[nlordell]

Wow, Thanks!

[anxolin]

To prevent discrepancies into the API and swagger, would it be a good idea to auto-generate the swaggers using a Macro?

[vkgnosis]

To prevent discrepancies into the API and swagger, would it be a good idea to auto-generate the swaggers using a Macro?

It would be nice to generate the rust code for using and serving the API from the openapi spec, yes. I'm not aware of a tool that can do this. But it's been a while since we checked that.

[vkgnosis]

I'm surprised the missing types weren't found by our openapi linter.

[github-actions]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[anxolin]

To prevent discrepancies into the API and swagger, would it be a good idea to auto-generate the swaggers using a Macro?
It would be nice to generate the rust code for using and serving the API from the openapi spec, yes. I'm not aware of a tool that can do this. But it's been a while since we checked that.

In case it helps
Automated OpenAPI (AKA Swagger) document generation for Rust/Rocket projects.
Not sure how well it works

https://github.com/GREsau/okapi

Also https://lib.rs/crates/utoipa-gen

Utoipa crate provides auto generated OpenAPI documentation for Rust REST APIs. It treats code first approach as a first class citizen and simplifies API documentation by providing simple macros for generating the documentation from your code.

[shoom3301]

I have read the CLA Document and I hereby sign the CLA

[shoom3301]

recheck