Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK refactoring #3] Order-book code generated from Swagger #100

Merged
merged 15 commits into from
Feb 28, 2023

Conversation

shoom3301
Copy link
Contributor

@shoom3301 shoom3301 commented Feb 14, 2023

Docs: https://www.notion.so/cownation/FE-SDK-Dogfooding-our-own-SDK-in-CoW-Swap-ce502a2dfb3f423bb9c7998de4237575
Swagger: cowprotocol/services#1208
Explorer dogfooding: cowprotocol/explorer#352
General refactoring draft: #96

What changed

  1. Generated files for order-book API from Swagger scheme

@github-actions
Copy link

github-actions bot commented Feb 14, 2023

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@shoom3301 shoom3301 requested a review from a team February 14, 2023 11:36
Copy link
Contributor

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird to add generated types for basic things like request

Copy link
Contributor

@anxolin anxolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@shoom3301 shoom3301 merged commit 48bd75e into refactoring/dogfooding-2 Feb 28, 2023
@alfetopito alfetopito deleted the refactoring/dogfooding-3 branch March 1, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants