Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4] SDK dogfooding, lazy loading for signing utils #2071

Merged
merged 8 commits into from
Mar 6, 2023

Conversation

shoom3301
Copy link
Collaborator

@shoom3301 shoom3301 commented Feb 24, 2023

SDK refactoring: cowprotocol/cow-sdk#97

Changes

  1. Added lazy loading for signing utils from @cowprotocol/contracts, because they are pretty heavy and we don't need them most of the time

@vercel
Copy link

vercel bot commented Feb 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
swap-dev 🔄 Building (Inspect) Visit Preview

🌃 Cosmos ↗︎

@shoom3301 shoom3301 changed the title [DRAFT] SDK dogfooding 4 [#4] SDK dogfooding Feb 28, 2023
@shoom3301 shoom3301 changed the title [#4] SDK dogfooding [#4] SDK dogfooding, lazy loading for signing utils Feb 28, 2023
@shoom3301 shoom3301 self-assigned this Feb 28, 2023
@shoom3301 shoom3301 requested a review from a team February 28, 2023 11:11
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks

@shoom3301 shoom3301 marked this pull request as ready for review March 6, 2023 14:25
@shoom3301 shoom3301 merged commit 1f61b14 into sdk-dogfooding/order-book-3 Mar 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2023
@alfetopito alfetopito deleted the sdk-dogfooding/order-book-4 branch March 20, 2023 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants