Release v2.13.0 #214

henrypalacios · 2022-09-15T03:07:00Z

Release v2.13.0

🚨🚨 DON'T SQUASH 🚨🚨

Main Features

A more flexible menu is incorporated in the Home page along the same lines as swap.cow.fi 🐮
Improved usability of the /appdata page such as clear descriptions, user experience, to handle JSON meta data for CoW Protocol orders.
More granularity has been added to the weekly price chart 📈 displayed on the Home page

Change Log

dd0c91b Bump version to 2.13.0
66b62c0 New Menu (#186)
7f5cadd change position: fixed -> sticky (#209)
3cdced4 [App Data] Add more context (#204)
5051af5 [Tokens Table] Change query to use tokenHourlyTotals for tokens table (#211)
5b87f76 remove unused values (#203)
2b496c4 [AppData] Store data when switching beetween tabs (#202)
3e34d03 [Top Tokens Table] Rename some columns (#197)
f14f688 map explorer->api envs explicitly (#201)
5aaf119 Merge pull request #198 from cowprotocol/main

* Fix issue displaying the execution * Fixed bug with sellAmount partial fills in the filled row * Updated order details tooptips to account for the fee inclusion/exclusion Co-authored-by: Anxo Rodriguez <[email protected]>

Update develop branch with Release/v2.12.0

…#211)

* Add more context to the appData page * Fix styles + Update texts * Improve styles + readability * Fix styles * Fix styles * Improve styles + Remove description for appData * Fix decode section styles * Improve styling for decode page * fix font sizr

* add basic menu * fix storybook * add menu content * add menu and links styles * mobile improvements * mobile menu * navbar improvements * Fix conflict with styled-components * add icons and remove old menu * delete menu * toogle styles * show logo on mobile and fix ui issues * mobile improvements * add dark bg color * fix routes and constants part 1 * const error fix * change links to routes fromo const * remove const folder - to be refactored in a new PR * menu logic * fix husky error * menu logic * fix menu color on mobile * Fix navbar * icons tets * Convert file to .tsx * Add icon type * Fix icon type * Fix network redirect * fix style home link on mobile * feedback point 5 - mobile links * Display icons on menu dropdown * Fix problems with typing * Move menuContainer * Fix clickoutside * Fix when clickCloseMenuMobile, unify screenSizes mediaqueries * Remove escaped log * Fix close mobile menu click when click on Logo * Fix hide mobile mene when clicking on an internal Link * add icons to the menu * change logo animation as we have on CoWSwap * add external link icon * fix logo animation * fix cow icon size * remove svg styles * removed internal link attributes * feddback 2. Removed logo animation on mobile. * header improvement * remove globally touch highlight color effect * feedback 5: fix scrollbar on mobile * feedback 4: fix menu on medium and desktop * menu: App Data -> AppData * delete commented code * fix logo on mobile avoid opening the menu * feedback 3: landscape mode on mobile * menu item height * code improvements * fix storybook * fix dropdown stories * add MainMenu storybook * Moving MenuIcon inside MenuTree component, addin mobile behavior to the storybook * fix menu alignment on mobile * change dropdown component storybook * change component name Co-authored-by: Henry Palacios <[email protected]> Co-authored-by: Mati Dastugue <[email protected]>

coveralls · 2022-09-15T03:09:53Z

Pull Request Test Coverage Report for Build 3106849932

16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.07%) to 43.855%

Totals
Change from base Build 2908130418:	0.07%
Covered Lines:	2175
Relevant Lines:	4209

💛 - Coveralls

github-actions · 2022-09-15T03:13:12Z

🔭 Explorer: Explorer test app
🔒 Safe Swap App: Trade test app (add to your safe apps)
📈 Trade: Trade test app
📚 Storybook: Component stories

alfetopito · 2022-09-15T09:33:06Z

2 things about the menu:

Not aligned on FF and Safari (ok on Chrome)

The menu arrow rotation is not centered

Screen.Recording.2022-09-15.at.11.24.43.mov

elena-zh · 2022-09-15T11:18:06Z

2 things about the menu:

Not aligned on FF and Safari (ok on Chrome)

The menu arrow rotation is not centered

Screen.Recording.2022-09-15.at.11.24.43.mov

Maybe to add, it would be great to add 'font-family' param to the dropdown button as it looks different with the Home button option. See the comparison:

without the param (the current view):
with 'font-family' param:

alongoni · 2022-09-15T12:45:52Z

The menu arrow rotation is not centered

Screen.Recording.2022-09-15.at.11.24.43.mov

Thanks @alfetopito. Here in storybook it's working properly for me in FF and Chrome. I'll take a look.

elena-zh · 2022-09-15T12:46:07Z

I have reviewed the PR and here are issues I found (besides reported but @alfetopito above):

Add font property to the menu and action buttons on the AppData page #217 - issue I reported above, related to the font param for buttons in Explorer (not only for menu button)
Use the same spelling for AppData inside sentences #216 - I think, it will be easy to fix
[Mobile] AppData sections are expanded, unnecessary scroll bar appears when press on Generate button #215 - low priority, but would great to take a look at it in the next iteration, I think.

* fix aligment and font family * fix dropdown arrow * add Inter font-family to prevent any font system * menu css refactor * add arrow transition on close event * fix arrow rotation axis on mobile

For the 7 days price chart after changing the precision from days to hours the response is capped to 100 records and that doesn't cover all records from the past week

…pended

elena-zh

LGTM with some issues I reported above.

anxolin

The menu looks great.

Happy to deploy this one, but we need to address a few minor issues.

This phrase sounds a bit weird. I'm not the best to make a suggestion here, but I will try to suggest something.

The appData it's an optional field part of CoW Protocol orders. It allows users/dapps/wallets to attach meta-information to orders. This is useful for giving context to your orders, like crediting the order to a specific UI, adding affiliate information, or even signalling your order should be treated in a special way.  

This field is the hexadecimal digest of an IPFS document’s CID of a JSON file.

The JSON file follows a JSON schema defined on app-data[repo.](https://github.com/cowprotocol/app-data)

Also, the link to Dune is old. It returns a 404. I see its also bad in CoW Swap.
If possible, could you update in CoW Swap and cow-fi too?
Good one is https://dune.com/cowprotocol/Gnosis-Protocol-V2

elena-zh · 2022-09-22T16:13:32Z

New changes LGTM!

nenadV91 · 2022-09-23T12:49:02Z

Did a post merge review but LGTM 👍

alfetopito and others added 12 commits August 19, 2022 07:18

183/fix filled amount issues 2 (#192)

bf1eca9

* Fix issue displaying the execution * Fixed bug with sellAmount partial fills in the filled row * Updated order details tooptips to account for the fee inclusion/exclusion Co-authored-by: Anxo Rodriguez <[email protected]>

Hardcode zero address for ipfs fetching (#194)

b4a87ce

Merge pull request #198 from cowprotocol/main

5aaf119

Update develop branch with Release/v2.12.0

map explorer->api envs explicitly (#201)

f14f688

[Top Tokens Table] Rename some columns (#197)

3e34d03

[AppData] Store data when switching beetween tabs (#202)

2b496c4

remove unused values (#203)

5b87f76

[Tokens Table] Change query to use tokenHourlyTotals for tokens table (…

5051af5

…#211)

[App Data] Add more context (#204)

3cdced4

* Add more context to the appData page * Fix styles + Update texts * Improve styles + readability * Fix styles * Fix styles * Improve styles + Remove description for appData * Fix decode section styles * Improve styling for decode page * fix font sizr

change position: fixed -> sticky (#209)

7f5cadd

Bump version to 2.13.0

dd0c91b

henrypalacios added app:Explorer Explorer App Protofire RELEASE labels Sep 15, 2022

henrypalacios added this to the 2.13.0 milestone Sep 15, 2022

henrypalacios requested review from a team September 15, 2022 03:07

henrypalacios self-assigned this Sep 15, 2022

ramirotw removed this from the 2.13.0 milestone Sep 15, 2022

This was referenced Sep 15, 2022

[Mobile] AppData sections are expanded, unnecessary scroll bar appears when press on Generate button #215

Closed

Use the same spelling for AppData inside sentences #216

Closed

Add font property to the menu and action buttons on the AppData page #217

Closed

alongoni mentioned this pull request Sep 15, 2022

UI improvements for Release 2.13.0 #218

Merged

alongoni and others added 4 commits September 16, 2022 13:34

UI improvements for Release 2.13.0 (#218)

b167a4a

* fix aligment and font family * fix dropdown arrow * add Inter font-family to prevent any font system * menu css refactor * add arrow transition on close event * fix arrow rotation axis on mobile

fix token hourly query fetching only 100 records

f64a35e

For the 7 days price chart after changing the precision from days to hours the response is capped to 100 records and that doesn't cover all records from the past week

fix native tokens historical data in the tokens table which wasn't ap…

8b6a6de

…pended

Fix Last day usd volume calculation in tokens table

b422614

elena-zh approved these changes Sep 19, 2022

View reviewed changes

ramirotw requested a review from a team September 19, 2022 14:02

ramirotw approved these changes Sep 19, 2022

View reviewed changes

anxolin reviewed Sep 21, 2022

View reviewed changes

alongoni added 2 commits September 21, 2022 18:54

update dune analytics URL

2beb4e4

change encode intro text

507358c

alongoni requested a review from anxolin September 22, 2022 15:46

henrypalacios merged commit b03701f into main Sep 22, 2022

henrypalacios deleted the release/2.13.0 branch September 22, 2022 18:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v2.13.0 #214

Release v2.13.0 #214

henrypalacios commented Sep 15, 2022 •

edited

Loading

coveralls commented Sep 15, 2022 •

edited

Loading

github-actions bot commented Sep 15, 2022

alfetopito commented Sep 15, 2022

elena-zh commented Sep 15, 2022

alongoni commented Sep 15, 2022

elena-zh commented Sep 15, 2022

elena-zh left a comment

anxolin left a comment

elena-zh commented Sep 22, 2022

nenadV91 commented Sep 23, 2022

Release v2.13.0 #214

Release v2.13.0 #214

Conversation

henrypalacios commented Sep 15, 2022 • edited Loading

Release v2.13.0

Main Features

Change Log

coveralls commented Sep 15, 2022 • edited Loading

Pull Request Test Coverage Report for Build 3106849932

💛 - Coveralls

github-actions bot commented Sep 15, 2022

alfetopito commented Sep 15, 2022

elena-zh commented Sep 15, 2022

alongoni commented Sep 15, 2022

elena-zh commented Sep 15, 2022

elena-zh left a comment

Choose a reason for hiding this comment

anxolin left a comment

Choose a reason for hiding this comment

elena-zh commented Sep 22, 2022

nenadV91 commented Sep 23, 2022

henrypalacios commented Sep 15, 2022 •

edited

Loading

coveralls commented Sep 15, 2022 •

edited

Loading