Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

[Appdata] json section position #209

Merged
merged 1 commit into from
Sep 13, 2022
Merged

[Appdata] json section position #209

merged 1 commit into from
Sep 13, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Sep 7, 2022

Summary

Closes #199
Now json section does not overlap screen boarder.
Regarding borders:
On medium and small devices, we intentionally hide the borders on the main container. Visually, it looks more simple.

To test

  1. Open AppData page https://pr209--explorer.review.gnosisdev.com/appdata?tab=encode
  2. Fill in ALL the fields, press on the Generate button
  3. Scroll down

@alongoni alongoni added app:Explorer Explorer App Bug Something isn't working Protofire labels Sep 7, 2022
@alongoni alongoni self-assigned this Sep 7, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3011286483

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.788%

Totals Coverage Status
Change from base Build 2951506391: 0.0%
Covered Lines: 2158
Relevant Lines: 4177

💛 - Coveralls

@alongoni alongoni marked this pull request as ready for review September 7, 2022 23:05
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Copy link

@elena-zh elena-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alongoni alongoni merged commit 7f5cadd into develop Sep 13, 2022
@alongoni alongoni deleted the 199-json-position branch September 13, 2022 18:08
@henrypalacios henrypalacios mentioned this pull request Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
app:Explorer Explorer App Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppData: json section goes beyond the page boarders when generate a hash and scroll down
4 participants