Skip to content
This repository was archived by the owner on Feb 2, 2024. It is now read-only.

UI improvements for Release 2.13.0 #218

Merged
merged 6 commits into from
Sep 16, 2022
Merged

UI improvements for Release 2.13.0 #218

merged 6 commits into from
Sep 16, 2022

Conversation

alongoni
Copy link
Contributor

@alongoni alongoni commented Sep 15, 2022 •
edited
Loading

Summary

Closes #217
image

To test:

  1. Check the main menu alignment.
  2. Check the font-family on the AppData page buttons.
  3. Check the arrow animation on the dropdown option on the main menu. It should rotate 180º in the same axis. Reported here by @alfetopito

NOTE:

We need to solve a major issue regarding Inter var font that it's missing. We'll be working in a different PR to solve that.

@alongoni alongoni added app:Explorer Explorer App Bug Something isn't working Protofire labels Sep 15, 2022
@alongoni alongoni self-assigned this Sep 15, 2022
@github-actions
Copy link

@alongoni alongoni marked this pull request as ready for review September 15, 2022 23:59
@alongoni alongoni requested a review from elena-zh September 16, 2022 01:43
@elena-zh elena-zh mentioned this pull request Sep 16, 2022
Closed
@elena-zh
Copy link

Hey @alongoni , changes LGTM!
I have created #219 issue for fixing fonts in a different PR.

Thanks!

henrypalacios
henrypalacios approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@henrypalacios henrypalacios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked as Expected!

@alongoni alongoni merged commit b167a4a into release/2.13.0 Sep 16, 2022
@alongoni alongoni deleted the ui-improvements branch September 16, 2022 16:34
@alongoni alongoni mentioned this pull request Sep 16, 2022
Closed
alfetopito
alfetopito reviewed Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@alfetopito alfetopito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

matextrem pushed a commit that referenced this pull request Sep 28, 2022
@alongoni @matextrem
UI improvements for Release 2.13.0 (#218)
a3ed063 
* fix aligment and font family

* fix dropdown arrow

* add Inter font-family to prevent any font system

* menu css refactor

* add arrow transition on close event

* fix arrow rotation axis on mobile
matextrem pushed a commit that referenced this pull request Oct 3, 2022
@alongoni @matextrem
UI improvements for Release 2.13.0 (#218)
60e61ad 
* fix aligment and font family

* fix dropdown arrow

* add Inter font-family to prevent any font system

* menu css refactor

* add arrow transition on close event

* fix arrow rotation axis on mobile
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alfetopito alfetopito alfetopito left review comments

@ramirotw ramirotw ramirotw approved these changes

@henrypalacios henrypalacios henrypalacios approved these changes

@elena-zh elena-zh elena-zh approved these changes

Assignees

@alongoni alongoni

Labels
app:Explorer Explorer App Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alongoni @elena-zh @alfetopito @ramirotw @henrypalacios