-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more to the CUDA arch migration #2699
Add more to the CUDA arch migration #2699
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Are you adding all cuda feedstocks to the aarch64/ppc64le migrator? |
What I've noticed with the CUDA arch migrator (and maybe we should discuss this in a new issue), is it seems to be migrating all CUDA packages regardless of whether they are in this list. For example ( conda-forge/cudadecon-feedstock#11 ). The result is it adds the files necessary to build CUDA packages on other archs, but doesn't actually enable the builds. Even though we have Now admittedly I'm not sure the right way to solve it and this may not be it. Admittedly one answer might be do nothing since adding the additional migration files doesn't break anything and if we do intend to do arch migration the functionality is there. Though if that is the case, maybe we should consolidate this migrator with other the CUDA migrator and drop Personally don't have any strong feelings on any of these options and am ok cutting this list down to a subset, but I think it would be good to come up with some solution since the current behavior is a bit confusing. |
This seems like the best option. |
Agree though I don't really know that codebase well enough to do that. Am ok trimming back this list in the interim though. |
conda-forge/cudadecon-feedstock#11 was sent before I fixed the issue in regro/cf-scripts#1517 |
Ah ok. Thanks for point that out. Though it is worth noting the packages here came from the "Awaiting Parents" list under the CUDA arch migrator. So not sure why those are showing up then (unless they are coming from things already in the list or we still have another issue) |
That's a labeling issue and you can ignore that. (Awaiting Parents include awaiting the normal arch migrator) |
If you agree, can you remove any feedstocks you don't need that you added here? |
Ok glad to hear that is a non-issue. Sorry for the confusion. Yeah I've been working on that background. Should have a PR in a moment. |
What should we do about the one's marked "Done" that did not go through regular arch migration, but did go through CUDA migration? |
Either delete https://github.com/regro/cf-graph-countyfair/blob/master/node_attrs/cudadecon.json#L117-L135 and similar |
Ok starting with trimming the list. Submitted PR ( #2700 ). Will take a look at node removal as that seems less disruptive. Though may not get to that tonight (repo is cloning though 😉). |
Went through and deleted the CUDA arch migration from the nodes that were marked done, but did not undergo the arch migration first. Have submitted these changes in PR ( https://github.com/regro/cf-graph-countyfair/pull/41 ). |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)