Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more to the CUDA arch migration #2699

Merged

Conversation

jakirkham
Copy link
Member

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@jakirkham jakirkham requested a review from a team as a code owner April 2, 2022 02:59
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham jakirkham added the automerge Merge the PR when CI passes label Apr 2, 2022
@github-actions github-actions bot merged commit 308eeff into conda-forge:main Apr 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@jakirkham jakirkham deleted the more_cuda_arch branch April 2, 2022 03:02
@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

Are you adding all cuda feedstocks to the aarch64/ppc64le migrator?
Consensus in #2436 was that we should add only feedstocks that you need.

@jakirkham
Copy link
Member Author

What I've noticed with the CUDA arch migrator (and maybe we should discuss this in a new issue), is it seems to be migrating all CUDA packages regardless of whether they are in this list. For example ( conda-forge/cudadecon-feedstock#11 ). The result is it adds the files necessary to build CUDA packages on other archs, but doesn't actually enable the builds. Even though we have wait_for_migrators, it isn't really waiting.

Now admittedly I'm not sure the right way to solve it and this may not be it. Admittedly one answer might be do nothing since adding the additional migration files doesn't break anything and if we do intend to do arch migration the functionality is there. Though if that is the case, maybe we should consolidate this migrator with other the CUDA migrator and drop wait_for_migrators. Another option is to add the packages to the arch migrator ahead of time so we don't get these CUDA arch migrator PRs that are not really doing anything, but as you note this is opting more packages into arch migration than we may really want to add. Perhaps a different approach is we do some debugging in cf-scripts to figure out why this is happening and fix it and/or move some of the CUDA arch migrator logic into the arch migrator there.

Personally don't have any strong feelings on any of these options and am ok cutting this list down to a subset, but I think it would be good to come up with some solution since the current behavior is a bit confusing.

@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

Perhaps a different approach is we do some debugging in cf-scripts to figure out why this is happening and fix it and/or move some of the CUDA arch migrator logic into the arch migrator there.

This seems like the best option.

@jakirkham
Copy link
Member Author

Agree though I don't really know that codebase well enough to do that.

Am ok trimming back this list in the interim though.

@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

conda-forge/cudadecon-feedstock#11 was sent before I fixed the issue in regro/cf-scripts#1517

@jakirkham
Copy link
Member Author

Ah ok. Thanks for point that out.

Though it is worth noting the packages here came from the "Awaiting Parents" list under the CUDA arch migrator. So not sure why those are showing up then (unless they are coming from things already in the list or we still have another issue)

@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

That's a labeling issue and you can ignore that. (Awaiting Parents include awaiting the normal arch migrator)

@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

If you agree, can you remove any feedstocks you don't need that you added here?

@jakirkham
Copy link
Member Author

jakirkham commented Apr 2, 2022

Ok glad to hear that is a non-issue. Sorry for the confusion.

Yeah I've been working on that background. Should have a PR in a moment.

@jakirkham
Copy link
Member Author

What should we do about the one's marked "Done" that did not go through regular arch migration, but did go through CUDA migration?

@isuruf
Copy link
Member

isuruf commented Apr 2, 2022

Either delete https://github.com/regro/cf-graph-countyfair/blob/master/node_attrs/cudadecon.json#L117-L135 and similar
or restart the migration.

@jakirkham
Copy link
Member Author

jakirkham commented Apr 2, 2022

Ok starting with trimming the list. Submitted PR ( #2700 ).

Will take a look at node removal as that seems less disruptive. Though may not get to that tonight (repo is cloning though 😉).

@jakirkham
Copy link
Member Author

Went through and deleted the CUDA arch migration from the nodes that were marked done, but did not undergo the arch migration first. Have submitted these changes in PR ( https://github.com/regro/cf-graph-countyfair/pull/41 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants