Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that all migrators are waited for #1517

Merged
merged 1 commit into from
Mar 25, 2022
Merged

check that all migrators are waited for #1517

merged 1 commit into from
Mar 25, 2022

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Mar 24, 2022

@jakirkham
Copy link
Contributor

Thanks Isuru! 😄

cc @beckermr (in case you have thoughts here 🙂)

@beckermr
Copy link
Contributor

We may get questions about PRs that never get issued if the bot somehow cannot find the old metadata. It may be better to err on the side of issuing PRs and letting people deal with them. However, I have nothing against this PR. The tests are flaky so unless the failure looks bad, feel free to merge!

LGTM!

@isuruf
Copy link
Member Author

isuruf commented Mar 25, 2022

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants