Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARM + CUDA packages #149

Closed
bdice opened this issue Nov 30, 2022 · 6 comments · Fixed by #224
Closed

Add ARM + CUDA packages #149

bdice opened this issue Nov 30, 2022 · 6 comments · Fixed by #224

Comments

@bdice
Copy link

bdice commented Nov 30, 2022

Builds of the package for aarch64 (ARM) with CUDA support are missing and would be nice to have.

This would be helpful to RAPIDS cuDF, which uses PyTorch in its test suite for checking GPU interoperability. Currently cuDF is using an older pinning of pytorch/pytorch < 1.12.0 (rather than the conda-forge package) to get ARM + CUDA support. Newer versions on the pytorch channel are built with nvidia/cuda-toolkit instead of conda-forge/cudatoolkit, which leads to linker incompatibilities with libcupti.

cc: @jakirkham

@jakirkham
Copy link
Member

This was added to the arch migration indirectly by PR ( conda-forge/conda-forge-pinning-feedstock#504 ) and then directly in PR ( conda-forge/conda-forge-pinning-feedstock#2699 ). The latter being done after setting up the CUDA arch migrator ( conda-forge/conda-forge-pinning-feedstock#2527 )

The arch migration for PyTorch is started in PR ( #119 ). Though that handles the CPU case. The CUDA case is handled by a follow on CUDA arch migrator. Though both could be applied in a single PR (if preferred).

That all being said, the main challenge will be working through the build issues seen currently to get that to work.

@njzjz
Copy link
Member

njzjz commented Mar 8, 2024

When I tried it, I found the current build.sh cannot find the target CUDA correctly for cross-building.

  -- Could NOT find CUDA (missing: CUDA_TOOLKIT_ROOT_DIR) (found version "11.8")^M
  CMake Warning at cmake/public/cuda.cmake:31 (message):^M
    Caffe2: CUDA cannot be found.  Depending on whether you are building Caffe2^M
    or a Caffe2 dependent library, the next warning / error will give you more^M
    info.^M
  Call Stack (most recent call first):^M
    cmake/Dependencies.cmake:44 (include)^M
    CMakeLists.txt:722 (include)^M

@jakirkham
Copy link
Member

jakirkham commented Mar 8, 2024

We probably need this logic: #203 (comment)

Edit: This is for CUDA 12+ though

@jakirkham
Copy link
Member

Could you please share more about how you are doing the build? Preferably in a PR where we could more easily discuss changes

@njzjz
Copy link
Member

njzjz commented Mar 8, 2024

Could you please share more about how you are doing the build? Preferably in a PR where we could more easily discuss changes

#224

@jakirkham
Copy link
Member

Thanks Jinzhe! 🙏

Will keep an eye on that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants