Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy v6.0.0 #131

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • pyinstaller
  • dask
  • pytest
  • arm_pyart
  • requests
  • extension-helpers
  • matplotlib
  • astropy-iers-data

Packages found in the meta.yaml but not found by source code inspection:

  • importlib-metadata

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7013543937, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@@ -18,7 +18,7 @@ build:
- samp_hub = astropy.samp.hub_script:hub_script
- volint = astropy.io.votable.volint:main
- wcslint = astropy.wcs.wcslint:main
number: 2
number: 0
script: {{ PYTHON }} -m pip install . -vv
skip: true # [py<39]

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cython > 3.0.0 is needed (just below)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also probably good to pin numpy<2.0 for now (build and runtime)

@maxnoe
Copy link

maxnoe commented Nov 28, 2023

Instead of

{{ pin_compatible("numpy") }}

should we no require the minimum numpy required to build the ABI compatible bindings (i.e. numpy >=1.25) in run and host and then the lowest supported numpy under run?

This is what I have done now in eventio, see this diff:
https://github.com/conda-forge/eventio-feedstock/pull/29/files#diff-f3725a55bf339595bf865fec73bda8ac99f283b0810c205442021f29c06eea9a

or is pin_compatible still the right choice?

@neutrinoceros
Copy link
Contributor

https://numpy.org/doc/stable/dev/depending_on_numpy.html#adding-a-dependency-on-numpy still redirects to https://conda-forge.org/docs/maintainer/knowledge_base.html#building-against-numpy, which leads me to believe that we're already doing it the recommended way; as far as I understand, conda-forge has its own way to provide backward compatibility for packages built against numpy and there is no need to leverage numpy 1.25+ builtin mechanism here.

@pllim
Copy link
Contributor

pllim commented Nov 29, 2023

Maybe for now we just pin numpy >= 1.25 for build here? I don't think conda reads pyproject.toml .

@pllim pllim mentioned this pull request Nov 29, 2023
5 tasks
@neutrinoceros
Copy link
Contributor

I don't think conda reads pyproject.toml

I confirm that it doesn't

@maxnoe
Copy link

maxnoe commented Nov 29, 2023

conda-forge/conda-forge.github.io#2037

@pllim
Copy link
Contributor

pllim commented Nov 29, 2023

I got a bit further but I think we need to add astropy-iers-data to the recipe. Anyone knows if astropy-iers-data ever got into conda-forge? @astrofrog ?

#132

@astrofrog
Copy link
Contributor

astrofrog commented Nov 29, 2023

Yes: https://github.com/conda-forge/astropy-iers-data-feedstock (and that repo has auto merge enabled so that updates are fully automated)

@saimn
Copy link

saimn commented Nov 29, 2023

From https://conda-forge.org/docs/maintainer/knowledge_base.html#building-against-numpy I think there is no need to change anything about Numpy, at least for now: it will build with the oldest Numpy supported for a given Python version, which should be fine.
So we need to update the version of Cython, and indeed add astropy-iers-data 👍

@pllim
Copy link
Contributor

pllim commented Nov 29, 2023

it will build with the oldest Numpy supported for a given Python version, which should be fine.

Really? But we force numpy>=1.25 for build requirements in pip.

@maxnoe
Copy link

maxnoe commented Nov 29, 2023

Really? But we force numpy>=1.25 for build requirements in pip.

Because you make use of the new API to produce the wheels, as discussed in the issue(s) linked in the issue I opened above, that's not how conda-forge currently does it.

Building against the oldest supported numpy by conda-forge will have the same effect, being forward compatible with all newer versions of numpy.

@pllim
Copy link
Contributor

pllim commented Nov 29, 2023

Thanks for the help! It is green over at #132 but I cannot merge it.

@mwcraig mwcraig closed this in #132 Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants