-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is pin_compatible("numpy") still the recommended way of dealing with numpy after introduction of the new backwards compatiple C-API? #2037
Comments
I think for now we are still using the "old way". Note that conda-forge today targets numpy 1.22+ The discussions: are helpful to build context |
Yeah, |
I thought that the numpy feedstock defines its own run_exports now, so downstream recipes needn't do any pinning. i.e. It's the numpy feedstock maintainers who are responsible for pinnings. |
Yes, we'll actually remove the |
Looking at using a piggyback migrator to start making this change: regro/cf-scripts#2469 Though maintainers are welcome to start working on this sooner 🙂 |
Also we are planning to drop this from the docs xref: #2156 |
Your question:
Numpy 1.25 introduced a backwards compatible C-API with a definable minimum supported numpy version.
For a project defining
-DNPY_TARGET_VERSION NPY_1_21_API_VERSION
one could thus I think do:Given this new mechanism, is
{{ pin_compatible("numpy") }}
still the way to go?If not, we should update the knowledge base section on numpy.
The text was updated successfully, but these errors were encountered: