Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

astropy v6.0.0 (try 2) #132

Merged
merged 6 commits into from
Nov 29, 2023
Merged

astropy v6.0.0 (try 2) #132

merged 6 commits into from
Nov 29, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Nov 29, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

I cannot push to #131 so trying as a different PR.

Close #131

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@pllim
Copy link
Contributor Author

pllim commented Nov 29, 2023

For my own reference, here is what is in pyproject.toml but numpy 2 isn't out yet, so I am not gonna worry about it.

[build-system]
requires = ["setuptools",
            "setuptools_scm>=6.2",
            "cython>=3.0.0,<3.1.0",
            "numpy>=1.25,<2",
            "extension-helpers"]

@pllim
Copy link
Contributor Author

pllim commented Nov 29, 2023

It built but the testing phase failed with this:

ModuleNotFoundError: No module named 'astropy_iers_data'

Is astropy-iers-data on conda-forge? EDIT: I see a recipe. Let's hope it works!

@pllim pllim mentioned this pull request Nov 29, 2023
3 tasks
@pllim pllim marked this pull request as ready for review November 29, 2023 17:56
@mwcraig
Copy link
Contributor

mwcraig commented Nov 29, 2023

Thanks @pllim, merging!

@mwcraig mwcraig merged commit acb1e5a into conda-forge:main Nov 29, 2023
@pllim pllim deleted the pr-to-pr131 branch November 29, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants