Add this for future Blindspot recognition #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not sure if a boolean is good instead of sending the distance to object but it would be interesting to talk about this.
rbiasini
reviewed
Oct 1, 2019
| @@ -182,6 +182,7 @@ struct CarState { | |||
| altButton3 @8; | |||
| } | |||
| } | |||
| blindspot @27 :Bool; # Is there something blocking the lane change | |||
There was a problem hiding this comment.
I think at least distinguishing between left VS right should be required.
Also, maybe anything that has to do with perception should be handled by radard. I'll think about this.
|
I also thought that having both is good in the beginning. But if we limit the auto Lane change based on blinker on direction. You should only have a violation in that direction. Checking both sides requires more code on Toyota and does not give more valuable data. Later it could be used for crash avoidance. But that is another topic. |
|
Is this being used in forks? I'd be fine with upstreaming blindspot stuff. |
|
We are working on it currently |
|
Will reopen a PR to be up to date with master. |
arne182
added a commit
to arne182/cereal
that referenced
this pull request
Feb 3, 2020
continuation of commaai#7
ryleymcc
pushed a commit
to MoreTore/cereal
that referenced
this pull request
May 19, 2023
Kirito3481
pushed a commit
to Kirito3481/msgq
that referenced
this pull request
Dec 4, 2024
* NNFF: Cereal logging and startup alert * fill up lateralControlState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if a boolean is good instead of sending the distance to object but it would be interesting to talk about this.