Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-2.1: sql: don't panic on unexpected null in kvfetcher #35272

Merged
merged 1 commit into from
Feb 28, 2019
Merged

release-2.1: sql: don't panic on unexpected null in kvfetcher #35272

merged 1 commit into from
Feb 28, 2019

Conversation

asubiotto
Copy link
Contributor

Backport 1/1 commits from #35248.

/cc @cockroachdb/release


Closes #35083

Release note: None

@asubiotto asubiotto requested review from jordanlewis and a team February 28, 2019 18:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jordanlewis
Copy link
Member

LGTM but it needs a rebase to get a fix for 2.1 build issues.

@asubiotto
Copy link
Contributor Author

Thanks, should be good.

bors r=jordanlewis

@craig
Copy link
Contributor

craig bot commented Feb 28, 2019

Build failed

@asubiotto
Copy link
Contributor Author

Seems like a weird flake, the teamcity build passed

bors r=jordanlewis

craig bot pushed a commit that referenced this pull request Feb 28, 2019
35272: release-2.1: sql: don't panic on unexpected null in kvfetcher r=jordanlewis a=asubiotto

Backport 1/1 commits from #35248.

/cc @cockroachdb/release

---

Closes #35083

Release note: None


Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
@craig
Copy link
Contributor

craig bot commented Feb 28, 2019

Build succeeded

@craig craig bot merged commit 4ffe666 into cockroachdb:release-2.1 Feb 28, 2019
@asubiotto asubiotto deleted the backport2.1-35248 branch March 1, 2019 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants