sql: don't panic on unexpected null in kvfetcher

Closes #35083

Release note: None

pkg/sql/sqlbase/rowfetcher.go

@@ -25,6 +25,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/internal/client"
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/roachpb"
+	"github.com/cockroachdb/cockroach/pkg/sql/pgwire/pgerror"
 	"github.com/cockroachdb/cockroach/pkg/sql/scrub"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
 	"github.com/cockroachdb/cockroach/pkg/storage/engine"
@@ -1238,16 +1239,15 @@ func (rf *RowFetcher) finalizeRow() error {
 						indexColValues = append(indexColValues, "?")
 					}
 				}
-				if rf.isCheck {
-					return scrub.WrapError(scrub.UnexpectedNullValueError, errors.Errorf(
-						"Non-nullable column \"%s:%s\" with no value! Index scanned was %q with the index key columns (%s) and the values (%s)",
-						table.desc.Name, table.cols[i].Name, table.index.Name,
-						strings.Join(table.index.ColumnNames, ","), strings.Join(indexColValues, ",")))
-				}
-				panic(fmt.Sprintf(
+				err := pgerror.NewAssertionErrorf(
 					"Non-nullable column \"%s:%s\" with no value! Index scanned was %q with the index key columns (%s) and the values (%s)",
 					table.desc.Name, table.cols[i].Name, table.index.Name,
-					strings.Join(table.index.ColumnNames, ","), strings.Join(indexColValues, ",")))
+					strings.Join(table.index.ColumnNames, ","), strings.Join(indexColValues, ","))
+
+				if rf.isCheck {
+					return scrub.WrapError(scrub.UnexpectedNullValueError, err)
+				}
+				return err
 			}
 			table.row[i] = EncDatum{
 				Datum: tree.DNull,