Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: don't panic on unexpected null in kvfetcher #35083

Closed
jordanlewis opened this issue Feb 20, 2019 · 1 comment
Closed

sql: don't panic on unexpected null in kvfetcher #35083

jordanlewis opened this issue Feb 20, 2019 · 1 comment
Assignees
@asubiotto

Comments

@jordanlewis
Copy link
Member

CockroachDB currently panics if a NULL is detected on disk for a non-nullable column. This is pretty much an overreaction to a situation that can arise due to bugs in our code. We should return an error in the query instead.
@jordanlewis jordanlewis self-assigned this Feb 20, 2019
@jordanlewis jordanlewis mentioned this issue Feb 20, 2019
Closed
@jordanlewis jordanlewis assigned asubiotto and unassigned jordanlewis Feb 21, 2019
@jordanlewis
Copy link
Member Author

@asubiotto could you knock this one out?

@asubiotto asubiotto mentioned this issue Feb 27, 2019
Merged
craig bot pushed a commit that referenced this issue Feb 28, 2019
@asubiotto
Merge #35248
a6175ff 
35248: sql: don't panic on unexpected null in kvfetcher r=jordanlewis a=asubiotto

Closes #35083

Release note: None

Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
@asubiotto asubiotto mentioned this issue Feb 28, 2019
Merged
@craig craig bot closed this as completed in #35248 Feb 28, 2019
craig bot pushed a commit that referenced this issue Feb 28, 2019
@asubiotto
Merge #35272
f28aa78 
35272: release-2.1: sql: don't panic on unexpected null in kvfetcher r=jordanlewis a=asubiotto

Backport 1/1 commits from #35248.

/cc @cockroachdb/release

---

Closes #35083

Release note: None


Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
@asubiotto asubiotto mentioned this issue Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asubiotto asubiotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordanlewis @asubiotto