logictest: disable autocommit_before_ddl under 3node-tenant #140187
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
yuzefovich
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rafiss)
A recent change to the default value of this setting appears to have made many 3node-tenant tests flaky. This patch goes back to the old value for multitenant configs while we investigate. Release note: None
rafiss
force-pushed
the
disable-autocommit-ddl-3node-tenant
branch
from
f3fea2c to
c511eb7
Compare
|
tftr! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
140187: logictest: disable autocommit_before_ddl under 3node-tenant r=rafiss a=rafiss A recent change to the default value of this setting appears to have made many 3node-tenant tests flaky. This patch goes back to the old value for multitenant configs while we investigate. informs #140162, #140163, #140170, #140172, #140183, #140182, #140173, #140171, #140168, #140164, Release note: None Co-authored-by: Rafi Shamim <[email protected]>
|
Build failed: |
|
Looks like unrelated flake on bors r+ |
This was referenced Jan 31, 2025
pkg/ccl/logictestccl/tests/3node-tenant/3node-tenant_test: TestTenantLogic_temp_table failed
#140225
Closed
Closed
Closed
rafiss
added a commit
to rafiss/cockroach
that referenced
this pull request
Jan 31, 2025
Similar to what we're seeing in cockroachdb#140172 and the issues linked to cockroachdb#140187, this test is flaky due to running with autocommit_before_ddl=true in a multitenant setup. Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
139365: docgen: update COPY TO STDOUT portions of SQL diagram r=mgartner a=taroface Updated `COPY` diagram so that it better reflects the `COPY TO` syntax that was added in 23.1 (this PR will be backported to every version up until 23.1). These changes accompany the docs updates in cockroachdb/docs#19310 Current diagram: <img width="647" alt="image" src="https://github.com/user-attachments/assets/eb70b831-3473-40aa-823f-5432a8cf2698" /> New diagram: <img width="829" alt="image" src="https://github.com/user-attachments/assets/314e1345-cec8-4a72-9be2-fb4b2f2885ee" /> Epic: none Release note: none Release justification: non-production code change 140071: storage: covert SizeSpec to protobuf r=RaduBerinde a=andrewbaptist This commit moves SizeSpec to the storagepb directory and converts it toa protobuf. Additionally it pulls shared storage into the global StorageConfig file. Epic: none Release note: None 140241: multiregionccl: deflake TestColdStartLatency r=rafiss a=rafiss Similar to what we're seeing in #140172 and the issues linked to #140187, this test is flaky due to running with autocommit_before_ddl=true in a multitenant setup. fixes #140174 Release note: None Co-authored-by: Ryan Kuo <[email protected]> Co-authored-by: Andrew Baptist <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
This was referenced Jan 31, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change to the default value of this setting appears to have made many 3node-tenant tests flaky. This patch goes back to the old value for multitenant configs while we investigate.
informs #140162, #140163, #140170, #140172, #140183, #140182, #140173, #140171, #140168, #140164,
Release note: None