Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiregionccl: deflake TestColdStartLatency #140241

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Jan 31, 2025

Similar to what we're seeing in
#140172 and the issues linked to #140187, this test is flaky due to running with autocommit_before_ddl=true in a multitenant setup.

fixes #140174
Release note: None

Similar to what we're seeing in
cockroachdb#140172 and the issues
linked to cockroachdb#140187, this
test is flaky due to running with autocommit_before_ddl=true in a
multitenant setup.

Release note: None
@rafiss rafiss requested review from fqazi and yuzefovich January 31, 2025 18:16
@rafiss rafiss requested a review from a team as a code owner January 31, 2025 18:16
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@fqazi fqazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@rafiss
Copy link
Collaborator Author

rafiss commented Jan 31, 2025

tftr!

bors r+

@craig craig bot merged commit 6a0a025 into cockroachdb:master Jan 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ccl/multiregionccl: TestColdStartLatency failed
3 participants