docgen: update COPY TO STDOUT portions of SQL diagram #139365
Merged
+15
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taroface
added
backport-23.1.x
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
taroface
force-pushed
the
copy-diagram
branch
from
fdae391 to
f82b7c8
Compare
|
bors r=mgartner |
craig bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
139365: docgen: update COPY TO STDOUT portions of SQL diagram r=mgartner a=taroface Updated `COPY` diagram so that it better reflects the `COPY TO` syntax that was added in 23.1 (this PR will be backported to every version up until 23.1). These changes accompany the docs updates in cockroachdb/docs#19310 Current diagram: <img width="647" alt="image" src="https://github.com/user-attachments/assets/eb70b831-3473-40aa-823f-5432a8cf2698" /> New diagram: <img width="829" alt="image" src="https://github.com/user-attachments/assets/314e1345-cec8-4a72-9be2-fb4b2f2885ee" /> Epic: none Release note: none Release justification: non-production code change Co-authored-by: Ryan Kuo <[email protected]>
|
Build failed: |
|
bors r=mgartner |
craig bot
pushed a commit
that referenced
this pull request
Jan 31, 2025
139256: sql/rowenc: reduce index key prefix calls r=annrpom a=annrpom ### sql/rowenc: reduce index key prefix calls This patch removes redundant calls to `MakeIndexKeyPrefix` during the construction of `IndexEntry`s by saving each first-time call in a map that we can later lookup. Previously, we would make this call for each row; however, as the prefix (table id + index id) for a particular index remains the same, we do not need to do any recomputation. Epic: [CRDB-42901](https://cockroachlabs.atlassian.net/browse/CRDB-42901) Fixes: #137798 Release note: None --- ### sql/rowexec: run BenchmarkIndexBackfill on-disk Epic: none Release note: None 139365: docgen: update COPY TO STDOUT portions of SQL diagram r=mgartner a=taroface Updated `COPY` diagram so that it better reflects the `COPY TO` syntax that was added in 23.1 (this PR will be backported to every version up until 23.1). These changes accompany the docs updates in cockroachdb/docs#19310 Current diagram: <img width="647" alt="image" src="https://github.com/user-attachments/assets/eb70b831-3473-40aa-823f-5432a8cf2698" /> New diagram: <img width="829" alt="image" src="https://github.com/user-attachments/assets/314e1345-cec8-4a72-9be2-fb4b2f2885ee" /> Epic: none Release note: none Release justification: non-production code change 140071: storage: covert SizeSpec to protobuf r=RaduBerinde a=andrewbaptist This commit moves SizeSpec to the storagepb directory and converts it toa protobuf. Additionally it pulls shared storage into the global StorageConfig file. Epic: none Release note: None Co-authored-by: Annie Pompa <[email protected]> Co-authored-by: Ryan Kuo <[email protected]> Co-authored-by: Andrew Baptist <[email protected]>
|
Build failed (retrying...): |
This was referenced Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
COPYdiagram so that it better reflects theCOPY TOsyntax that was added in 23.1 (this PR will be backported to every version up until 23.1). These changes accompany the docs updates in cockroachdb/docs#19310Current diagram:
New diagram:
Epic: none
Release note: none
Release justification: non-production code change