roachtest: surface cloud cluster spec info in artifacts #124243
Conversation
|
This change is |
vidit-bhat
force-pushed
the
roachtest-surface-vm-spec
branch
4 times, most recently
from
4dfb0fe to
5d7bc8c
Compare
vidit-bhat
requested review from
herkolategan,
nameisbhaskar,
srosenberg,
DarrylWong and
renatolabs
and removed request for
a team
| if err != nil { | ||
| return err | ||
| } | ||
| providerToVMs := bucketVMsByProvider(cachedCluster) |
There was a problem hiding this comment.
You could use vm.FanOut instead if you wanted to. Might be slightly simpler. It collates vms by a provider and calls the function passed to it, basically what you're doing here.
There was a problem hiding this comment.
Will take this up in a follow up PR. Do you think we should use vm.FanOut for GetPreemptedVMs and GetHostErrorVMs as well?
Yes that's the intention |
vidit-bhat
force-pushed
the
roachtest-surface-vm-spec
branch
2 times, most recently
from
33a1564 to
5021905
Compare
Previously, getting the spec of the VMs on which a roachtest ran was tricky to derive. This was inadequate because it's often necessary to understand the particulars of a roachtest run's environment. To address this, this patch creates a json file per VM describing its spec in. These files are stored in the Artifacts directory. Epic: none Fixes: cockroachdb#112707 Release note: None
vidit-bhat
force-pushed
the
roachtest-surface-vm-spec
branch
from
5021905 to
0e3ae2c
Compare
|
bors r+ |
This is a follow up PR to cockroachdb#124243. It implements the surfacing of cluster specs for aws and refactors logic in `cluster.go` to make it cloud agnostic. Epic: none Release note: None
This is a follow up PR to cockroachdb#124243. It implements the surfacing of cluster specs for aws and refactors logic in `cluster.go` to make it cloud agnostic. Epic: none Release note: None
124443: roachtest: surface cloud cluster spec info in artifacts for aws r=vidit-bhat a=vidit-bhat This is a follow up PR to #124243. It implements the surfacing of cluster specs for `aws` and refactors logic in `cluster.go` to make it cloud agnostic. Epic: none Release note: None Co-authored-by: Vidit Bhat <[email protected]>
|
blathers backport 24.1 23.2 |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 0e3ae2c to blathers/backport-release-23.2-124243: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.2 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This is a follow up PR to #124243. It implements the surfacing of cluster specs for aws and refactors logic in `cluster.go` to make it cloud agnostic. Epic: none Release note: None
Previously, getting the spec of the VMs on which a roachtest ran was tricky to derive.
This was inadequate because it's often necessary to understand the particulars of a roachtest run's environment.
To address this, this patch creates a json file per VM describing its spec. These files are stored under
artifacts/vm_spec.Epic: none
Fixes: #112707
Release note: None